Skip to content

Conversation

Krakazybik
Copy link
Member

@Krakazybik Krakazybik commented Feb 7, 2022

Description

Добавлено:
Поддержка сортировкой импортов из корня слоя

Example:

import { globalEntities } from "entities";

References

#75 (comment)

Checklist

  • Description added
  • Self-reviewed
  • CI pass

@Krakazybik Krakazybik self-assigned this Feb 7, 2022
@@ -20,7 +20,7 @@ module.exports = {
'newlines-between': 'always',
pathGroups: REVERSED_FS_LAYERS.map(
(layer) => ({
pattern: `**/?(*)${layer}/**` ,
pattern: `**/?(*)${layer}{,/**}`,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я хз что тут происходит, какой-то мэджик

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Рили магия какая-то)

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А, ну в целом понятно)

image

@Krakazybik Krakazybik requested a review from azinit February 7, 2022 20:35
@Krakazybik Krakazybik changed the title LINT-75(feedback): Incorrect imports sorting for layer imports LINT-75(feedback): Incorrect imports sorting for layer root imports Feb 7, 2022
@Krakazybik Krakazybik changed the title LINT-75(feedback): Incorrect imports sorting for layer root imports LINT-75(feedback): Incorrect sorting for layer root imports Feb 7, 2022
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отдельное спасибо за self-review комментарии!

@@ -20,7 +20,7 @@ module.exports = {
'newlines-between': 'always',
pathGroups: REVERSED_FS_LAYERS.map(
(layer) => ({
pattern: `**/?(*)${layer}/**` ,
pattern: `**/?(*)${layer}{,/**}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Рили магия какая-то)

image

@Krakazybik Krakazybik requested a review from azinit February 9, 2022 19:04
@azinit azinit merged commit 1eeb6c8 into master Feb 10, 2022
@azinit azinit deleted the feat/LINT-75-import-order-layer-based-imports branch February 10, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants