Skip to content

LINT-75(feedback): allow publicAPI for shared segments with _prefix #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 7, 2022
Merged

LINT-75(feedback): allow publicAPI for shared segments with _prefix #88

merged 5 commits into from
Feb 7, 2022

Conversation

Krakazybik
Copy link
Member

@Krakazybik Krakazybik commented Feb 4, 2022 •
edited
Loading

Description

Добавлена возможность использования кастомных сегментов с _ префиксом.

References

#75 (reply in thread)

Checklist

  • Description added
  • Self-reviewed
  • CI pass

@Krakazybik Krakazybik self-assigned this Feb 4, 2022
@Krakazybik Krakazybik requested a review from azinit February 4, 2022 18:44
@Krakazybik Krakazybik changed the title feat(public-api): God Mode(IDDQD) for publicAPI LINT-75(feedback): God Mode(IDDQD) for publicAPI Feb 4, 2022
@azinit
Copy link
Member

azinit commented Feb 5, 2022

😏

image

azinit
azinit suggested changes Feb 5, 2022
View reviewed changes
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кажется произошло недопонимание)))

@Krakazybik Krakazybik marked this pull request as draft February 5, 2022 18:55
@Krakazybik Krakazybik changed the title LINT-75(feedback): God Mode(IDDQD) for publicAPI LINT-75(feedback): allow publicAPI for shared segments with _prefix Feb 5, 2022
@Krakazybik Krakazybik marked this pull request as ready for review February 5, 2022 19:49
azinit
azinit reviewed Feb 5, 2022
View reviewed changes
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Получше, но есть еще вопросы)

@Krakazybik Krakazybik requested a review from azinit February 6, 2022 19:16
azinit
azinit approved these changes Feb 7, 2022
View reviewed changes
@Krakazybik Krakazybik requested a review from azinit February 7, 2022 06:08
@azinit azinit merged commit 71c2ed8 into master Feb 7, 2022
@azinit azinit deleted the feat/LINT-75-public-api-cheats branch February 7, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azinit azinit Awaiting requested review from azinit

Assignees

@Krakazybik Krakazybik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Krakazybik @azinit