feat: Allow to set registry server rest/grpc mode in operator #5364

ntkathole · 2025-05-17T17:07:50Z

What this PR does / why we need it:

This PR adds capability in feast-operator to allow user to deploy registry serving in REST or gRPC or both mode.

New configuration fields:

GRPC: Toggle gRPC server (--grpc/--no-grpc)
RestAPI: Toggle REST API server (--rest-api)
When REST API is enabled:
- Creates separate service with -rest suffix
- Configures dedicated REST API port
- Supports both HTTP/HTTPS
Service hostnames:
- Separate hostname for REST API endpoints
- Format: {service-name}-rest.{namespace}.svc.cluster.local:{port}
Maintains backward compatibility with existing gRPC deployments.

Setting restAPI: true will deploy registry with :
feast serve_registry --rest-api

spec:
  feastProject: example
  services:
    registry:
      local:
        server:
          restAPI: true
          grpc: true

Additionally, also fixed the issue in f231f0d with rest port not used when grpc is disabled and only rest-api is enabled. Earlier it was using default grpc port instead of default rest port.

infra/feast-operator/api/v1alpha1/featurestore_types.go

tchughesiv

when rest is enabled for registry, does the default port change?

ntkathole · 2025-05-18T05:37:20Z

when rest is enabled for registry, does the default port change?

nope, same default port is used, unless changed explicitly by user.

tchughesiv

@ntkathole please add unit tests to check that the rest option is being properly handled in the resulting Deployment object... and any other tests related to this PR that you think would be valuable. Also, please update the description to match any design changes that have occurred.

infra/feast-operator/api/v1alpha1/featurestore_types.go

infra/feast-operator/internal/controller/services/services.go

tchughesiv

Based on the failing e2e test around remote registry use, it's clear that using rest api mode will break registry's ability to be used as a "remote" provider type. this adds additional complexity that will need to be handled/checked ... likely in this method -

feast/infra/feast-operator/internal/controller/services/services.go

Lines 749 to 768 in 648c53d

    
           func (feast *FeastServices) setRemoteRegistryURL() error { 
        
           	if feast.isRemoteHostnameRegistry() { 
        
           		feast.Handler.FeatureStore.Status.ServiceHostnames.Registry = *feast.Handler.FeatureStore.Status.Applied.Services.Registry.Remote.Hostname 
        
           	} else if feast.IsRemoteRefRegistry() { 
        
           		remoteFeast, err := feast.getRemoteRegistryFeastHandler() 
        
           		if err != nil { 
        
           			return err 
        
           		} 
        
           		// referenced/remote registry must use the local registry server option and be in a 'Ready' state. 
        
           		if remoteFeast != nil && 
        
           			remoteFeast.isRegistryServer() && 
        
           			apimeta.IsStatusConditionTrue(remoteFeast.Handler.FeatureStore.Status.Conditions, feastdevv1alpha1.RegistryReadyType) && 
        
           			len(remoteFeast.Handler.FeatureStore.Status.ServiceHostnames.Registry) > 0 { 
        
           			feast.Handler.FeatureStore.Status.ServiceHostnames.Registry = remoteFeast.Handler.FeatureStore.Status.ServiceHostnames.Registry 
        
           		} else { 
        
           			return errors.New("Remote feast registry of referenced FeatureStore '" + remoteFeast.Handler.FeatureStore.Name + "' is not ready") 
        
           		} 
        
           	} 
        
           	return nil 
        
           }

If restAPI is true in the remote registry CR being used, we'd want to notify the user in the Status that remote provider registry capabilities cannot be used.

It would probably be good idea to check this in with a unit test as well. Maybe ensure whatever status message you set is being handled correctly.

There are existing remote registry tests in infra/feast-operator/internal/controller/featurestore_controller_test.go for reference. Might be a good place to add more.

infra/feast-operator/internal/controller/featurestore_controller_test.go

tchughesiv

looking good, but we still need checks added as mentioned in this prior review comment -
#5364 (review)

ntkathole · 2025-05-22T13:29:59Z

looking good, but we still need checks added as mentioned in this prior review comment - #5364 (review)

Can you provide an example here, I didn't get how user can set restAPI true in the remote registry ? I think we have only added restAPI flag option for local registry server configs.

tchughesiv · 2025-05-22T13:51:28Z

A user can reference a registry in another FeatureStore CR and use it as a remote registry -

feast/infra/feast-operator/test/testdata/feast_integration_test_crs/v1alpha1_remote_registry_featurestore.yaml

Lines 11 to 15 in 6c92447

    
           registry: 
        
             remote: 
        
               feastRef: 
        
                 name: simple-feast-setup 
        
                 namespace: default

We already have tests in place (both e2e & unit) around this feature. Given the restAPI breaks this functionality, you'll need to add an additional check in -

feast/infra/feast-operator/internal/controller/services/services.go

Lines 749 to 768 in 648c53d

    
           func (feast *FeastServices) setRemoteRegistryURL() error { 
        
           	if feast.isRemoteHostnameRegistry() { 
        
           		feast.Handler.FeatureStore.Status.ServiceHostnames.Registry = *feast.Handler.FeatureStore.Status.Applied.Services.Registry.Remote.Hostname 
        
           	} else if feast.IsRemoteRefRegistry() { 
        
           		remoteFeast, err := feast.getRemoteRegistryFeastHandler() 
        
           		if err != nil { 
        
           			return err 
        
           		} 
        
           		// referenced/remote registry must use the local registry server option and be in a 'Ready' state. 
        
           		if remoteFeast != nil && 
        
           			remoteFeast.isRegistryServer() && 
        
           			apimeta.IsStatusConditionTrue(remoteFeast.Handler.FeatureStore.Status.Conditions, feastdevv1alpha1.RegistryReadyType) && 
        
           			len(remoteFeast.Handler.FeatureStore.Status.ServiceHostnames.Registry) > 0 { 
        
           			feast.Handler.FeatureStore.Status.ServiceHostnames.Registry = remoteFeast.Handler.FeatureStore.Status.ServiceHostnames.Registry 
        
           		} else { 
        
           			return errors.New("Remote feast registry of referenced FeatureStore '" + remoteFeast.Handler.FeatureStore.Name + "' is not ready") 
        
           		} 
        
           	} 
        
           	return nil 
        
           }

and unit test(s) verifying the new check.. e.g. -

feast/infra/feast-operator/internal/controller/featurestore_controller_test.go

Lines 992 to 1010 in 6c92447

    
           cond := apimeta.FindStatusCondition(resource.Status.Conditions, feastdevv1alpha1.ReadyType) 
        
           Expect(cond).NotTo(BeNil()) 
        
           Expect(cond.Message).To(Equal("Error: FeatureStore '" + name + "' can't reference itself in `spec.services.registry.remote.feastRef`")) 
        
           resource.Spec.Services.Registry.Remote.FeastRef.Name = "wrong" 
        
           err = k8sClient.Update(ctx, resource) 
        
           Expect(err).NotTo(HaveOccurred()) 
        
           _, err = controllerReconciler.Reconcile(ctx, reconcile.Request{ 
        
           	NamespacedName: nsName, 
        
           }) 
        
           Expect(err).To(HaveOccurred()) 
        
           err = k8sClient.Get(ctx, nsName, resource) 
        
           Expect(err).NotTo(HaveOccurred()) 
        
           Expect(apimeta.FindStatusCondition(resource.Status.Conditions, feastdevv1alpha1.AuthorizationReadyType)).To(BeNil()) 
        
           Expect(apimeta.FindStatusCondition(resource.Status.Conditions, feastdevv1alpha1.RegistryReadyType)).To(BeNil()) 
        
           Expect(apimeta.IsStatusConditionTrue(resource.Status.Conditions, feastdevv1alpha1.ReadyType)).To(BeFalse()) 
        
           cond = apimeta.FindStatusCondition(resource.Status.Conditions, feastdevv1alpha1.ReadyType) 
        
           Expect(cond).NotTo(BeNil()) 
        
           Expect(cond.Message).To(Equal("Error: Referenced FeatureStore '" + resource.Spec.Services.Registry.Remote.FeastRef.Name + "' was not found"))

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

ntkathole · 2025-06-11T06:28:23Z

@tchughesiv Ready for review now

ntkathole · 2025-06-11T06:29:10Z

A user can reference a registry in another FeatureStore CR and use it as a remote registry -

feast/infra/feast-operator/test/testdata/feast_integration_test_crs/v1alpha1_remote_registry_featurestore.yaml

Lines 11 to 15 in 6c92447

registry:

remote:

feastRef:

name: simple-feast-setup

namespace: default

We already have tests in place (both e2e & unit) around this feature. Given the restAPI breaks this functionality, you'll need to add an additional check in -

feast/infra/feast-operator/internal/controller/services/services.go

Lines 749 to 768 in 648c53d

func (feast *FeastServices) setRemoteRegistryURL() error {

if feast.isRemoteHostnameRegistry() {

feast.Handler.FeatureStore.Status.ServiceHostnames.Registry = *feast.Handler.FeatureStore.Status.Applied.Services.Registry.Remote.Hostname

} else if feast.IsRemoteRefRegistry() {

remoteFeast, err := feast.getRemoteRegistryFeastHandler()

if err != nil {

return err

}

// referenced/remote registry must use the local registry server option and be in a 'Ready' state.

if remoteFeast != nil &&

remoteFeast.isRegistryServer() &&

apimeta.IsStatusConditionTrue(remoteFeast.Handler.FeatureStore.Status.Conditions, feastdevv1alpha1.RegistryReadyType) &&

len(remoteFeast.Handler.FeatureStore.Status.ServiceHostnames.Registry) > 0 {

feast.Handler.FeatureStore.Status.ServiceHostnames.Registry = remoteFeast.Handler.FeatureStore.Status.ServiceHostnames.Registry

} else {

return errors.New("Remote feast registry of referenced FeatureStore '" + remoteFeast.Handler.FeatureStore.Name + "' is not ready")

}

}

return nil

}

and unit test(s) verifying the new check.. e.g. -

feast/infra/feast-operator/internal/controller/featurestore_controller_test.go

Lines 992 to 1010 in 6c92447

cond := apimeta.FindStatusCondition(resource.Status.Conditions, feastdevv1alpha1.ReadyType)

Expect(cond).NotTo(BeNil())

Expect(cond.Message).To(Equal("Error: FeatureStore '" + name + "' can't reference itself in `spec.services.registry.remote.feastRef`"))

resource.Spec.Services.Registry.Remote.FeastRef.Name = "wrong"

err = k8sClient.Update(ctx, resource)

Expect(err).NotTo(HaveOccurred())

_, err = controllerReconciler.Reconcile(ctx, reconcile.Request{

NamespacedName: nsName,

})

Expect(err).To(HaveOccurred())

err = k8sClient.Get(ctx, nsName, resource)

Expect(err).NotTo(HaveOccurred())

Expect(apimeta.FindStatusCondition(resource.Status.Conditions, feastdevv1alpha1.AuthorizationReadyType)).To(BeNil())

Expect(apimeta.FindStatusCondition(resource.Status.Conditions, feastdevv1alpha1.RegistryReadyType)).To(BeNil())

Expect(apimeta.IsStatusConditionTrue(resource.Status.Conditions, feastdevv1alpha1.ReadyType)).To(BeFalse())

cond = apimeta.FindStatusCondition(resource.Status.Conditions, feastdevv1alpha1.ReadyType)

Expect(cond).NotTo(BeNil())

Expect(cond.Message).To(Equal("Error: Referenced FeatureStore '" + resource.Spec.Services.Registry.Remote.FeastRef.Name + "' was not found"))

This is handled in b991093 Thank you.

infra/feast-operator/internal/controller/services/services.go

infra/feast-operator/internal/controller/services/util.go

tchughesiv · 2025-06-11T14:12:47Z

Looking good, a few comments.

Co-authored-by: Tommy Hughes IV <tchughesiv@gmail.com> Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

tchughesiv

very close now, just a couple nits

infra/feast-operator/internal/controller/services/services.go

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

sdk/python/feast/cli/serve.py

infra/feast-operator/internal/controller/services/services.go

infra/feast-operator/api/v1alpha1/featurestore_types.go

tchughesiv

this whole block needs to change -

feast/infra/feast-operator/internal/controller/services/services.go

Lines 447 to 465 in f231f0d

    
           isRegistry := feastType == RegistryFeastType && feast.isRegistryServer() 
        
           grpcEnabled := !feast.isRegistryServer() || feast.isRegistryGrpcEnabled() 
        
           if grpcEnabled { 
        
           	container.Ports = append(container.Ports, corev1.ContainerPort{ 
        
           		Name:          name, 
        
           		ContainerPort: getTargetPort(feastType, tls), 
        
           		Protocol:      corev1.ProtocolTCP, 
        
           	}) 
        
           } 
        
           if isRegistry && feast.isRegistryRestEnabled() { 
        
           	container.Ports = append(container.Ports, corev1.ContainerPort{ 
        
           		Name:          name + "-rest", 
        
           		ContainerPort: getTargetRestPort(feastType, tls), 
        
           		Protocol:      corev1.ProtocolTCP, 
        
           	}) 
        
           }

the issue is that you're breaking the setting of ports for other service types (online, offline, etc)...
something like this should do the trick -

	if feastType == RegistryFeastType {
		if feast.isRegistryGrpcEnabled() {
			container.Ports = append(container.Ports, corev1.ContainerPort{
			    	Name:          name,
			    	ContainerPort: getTargetPort(feastType, tls),
			    	Protocol:      corev1.ProtocolTCP,
			})
		    }
		if feast.isRegistryRestEnabled() {
		    	container.Ports = append(container.Ports, corev1.ContainerPort{
		    		Name:          name + "-rest",
		    		ContainerPort: getTargetRestPort(feastType, tls),
		    		Protocol:      corev1.ProtocolTCP,
		    	})
		    }
        } else {
            container.Ports = append(container.Ports, corev1.ContainerPort{
		    	Name:          name,
		    	ContainerPort: getTargetPort(feastType, tls),
		    	Protocol:      corev1.ProtocolTCP,
            })
        }

the above would be done in addition to the other suggestions i've made around the isRegistryRestEnabled & isRegistryGrpcEnabled method changes

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

tchughesiv

looking good! one more change requested.

we also need unit tests for changes made around the rest & grpc container ports, services, probeHandlers, etc.

infra/feast-operator/api/v1alpha1/featurestore_types.go

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

infra/feast-operator/internal/controller/services/services.go

infra/feast-operator/test/api/featurestore_types_test.go

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

tchughesiv

lgtm

# [0.50.0](v0.49.0...v0.50.0) (2025-06-30) ### Bug Fixes * Add asyncio to integration test ([#5418](#5418)) ([6765515](6765515)) * Add clickhouse to OFFLINE_STORE_CLASS_FOR_TYPE map ([#5251](#5251)) ([9ed2ffa](9ed2ffa)) * Add missing conn.commit() in SnowflakeOnlineStore.online_write_batch ([#5432](#5432)) ([a83dd85](a83dd85)) * Add transformers in required dependencies ([8cde460](8cde460)) * Allow custom annotations on Operator installed objects ([#5339](#5339)) ([44c7a76](44c7a76)) * Dask pulling of latest data ([#5229](#5229)) ([571d81f](571d81f)) * **dask:** preserve remote URIs (e.g. s3://) in DaskOfflineStore path resolution ([2561cfc](2561cfc)) * Fix Event loop is closed error on dynamodb test ([#5480](#5480)) ([fe0f671](fe0f671)) * Fix lineage entity filtering ([#5321](#5321)) ([0d05701](0d05701)) * Fix list saved dataset api ([833696c](833696c)) * Fix NumPy - PyArrow array type mapping in Trino offline store ([#5393](#5393)) ([9ba9ded](9ba9ded)) * Fix pandas 2.x compatibility issue of Trino offline store caused by removed Series.iteritems() method ([#5345](#5345)) ([61e3e02](61e3e02)) * Fix polling mechanism for TestApplyAndMaterialize ([#5451](#5451)) ([b512a74](b512a74)) * Fix remote rbac integration tests ([#5473](#5473)) ([10879ec](10879ec)) * Fix Trino offline store SQL in Jinja template ([#5346](#5346)) ([648c53d](648c53d)) * Fixed CurlGeneratorTab github theme type ([#5425](#5425)) ([5f15329](5f15329)) * Increase the Operator Manager memory limits and requests ([#5441](#5441)) ([6c94dbf](6c94dbf)) * Method signature for push_async is out of date ([#5413](#5413)) ([28c3379](28c3379)), closes [#5410](#5410) [#006BB4](https://github.com/feast-dev/feast/issues/006BB4) * Operator - support securityContext override at Pod level ([#5325](#5325)) ([33ea0f5](33ea0f5)) * Pybuild-deps throws errors w/ latest pip version ([#5311](#5311)) ([f2d6a67](f2d6a67)) * Reopen for integration test about add s3 storage-based registry store in Go feature server ([#5352](#5352)) ([ef75f61](ef75f61)) * resolve Python logger warnings ([#5361](#5361)) ([37d5c19](37d5c19)) * The ignore_paths not taking effect duration feast apply ([#5353](#5353)) ([e4917ca](e4917ca)) * Update generate_answer function to provide correct parameter format to retrieve function ([dc5b2af](dc5b2af)) * Update milvus connect function to work with remote instance ([#5382](#5382)) ([7e5e7d5](7e5e7d5)) * Updating milvus connect function to work with remote instance ([#5401](#5401)) ([b89fadd](b89fadd)) * Upperbound limit for protobuf generation ([#5309](#5309)) ([a114aae](a114aae)) ### Features * Add CLI, SDK, and API documentation page to Feast UI ([#5337](#5337)) ([203e888](203e888)) * Add dark mode toggle to Feast UI ([#5314](#5314)) ([ad02e46](ad02e46)) * Add data labeling tabs to UI ([#5410](#5410)) ([389ceb7](389ceb7)), closes [#006BB4](https://github.com/feast-dev/feast/issues/006BB4) * Add Decimal to allowed python scalar types ([#5367](#5367)) ([4777c03](4777c03)) * Add feast rag retriver functionality ([#5405](#5405)) ([0173033](0173033)) * Add feature view curl generator ([#5415](#5415)) ([7a5b48f](7a5b48f)) * Add feature view lineage tab and filtering to home page lineage ([#5308](#5308)) ([308255d](308255d)) * Add feature view tags to dynamo tags ([#5291](#5291)) ([3a787ac](3a787ac)) * Add HybridOnlineStore for multi-backend online store routing ([#5423](#5423)) ([ebd67d1](ebd67d1)) * Add max_file_size to Snowflake config ([#5377](#5377)) ([e8cdf5d](e8cdf5d)) * Add MCP (Model Context Protocol) support for Feast feature server ([#5406](#5406)) ([de650de](de650de)), closes [#5398](#5398) [#5382](#5382) [#5389](#5389) [#5401](#5401) * Add rag project to default dev UI ([#5323](#5323)) ([3b3e1c8](3b3e1c8)) * Add s3 storage-based registry store in Go feature server ([#5336](#5336)) ([abe18df](abe18df)) * Add support for data labeling in UI ([#5409](#5409)) ([d183c4b](d183c4b)), closes [#27](#27) * Added Lineage APIs to get registry objects relationships ([#5472](#5472)) ([be004ef](be004ef)) * Added rest-apis serving option for registry server ([#5342](#5342)) ([9740fd1](9740fd1)) * Added torch.Tensor as option for online and offline retrieval ([#5381](#5381)) ([0b4ae95](0b4ae95)) * Adding feast delete to CLI ([#5344](#5344)) ([19fe3ac](19fe3ac)) * Adding permissions to UI and refactoring some things ([#5320](#5320)) ([6f1b0cc](6f1b0cc)) * Allow to set registry server rest/grpc mode in operator ([#5364](#5364)) ([99afd6d](99afd6d)) * Allow to use env variable FEAST_FS_YAML_FILE_PATH and FEATURE_REPO_DIR ([#5420](#5420)) ([6a1b33a](6a1b33a)) * Enable materialization for ODFV Transform on Write ([#5459](#5459)) ([3d17892](3d17892)) * Improve search results formatting ([#5326](#5326)) ([18cbd7f](18cbd7f)) * Improvements to Lambda materialization engine ([#5379](#5379)) ([b486f29](b486f29)) * Make batch_source optional in PushSource ([#5440](#5440)) ([#5454](#5454)) ([ae7e20e](ae7e20e)) * Refactor materialization engine ([#5354](#5354)) ([f5c5360](f5c5360)) * Remote Write to Online Store completes client / server architecture ([#5422](#5422)) ([2368f42](2368f42)) * Serialization version 2 and below removed ([#5435](#5435)) ([9e50e18](9e50e18)) * SQLite online retrieval. Add timezone info into timestamp. ([#5386](#5386)) ([6b05153](6b05153)) * Support dual-mode REST and gRPC for Feast Registry Server ([#5396](#5396)) ([fd1f448](fd1f448)) * Support DynamoDB as online store in Go feature server ([#5464](#5464)) ([40d25c6](40d25c6)) * Update Spark Compute read source node to be able to use other data sources ([#5445](#5445)) ([a93d300](a93d300)) ### Reverts * Feat: Add CLI, SDK, and API documentation page to Feast UI" ([#5341](#5341)) ([b492f14](b492f14)), closes [#5337](#5337) * Revert "feat: Add s3 storage-based registry store in Go feature server" ([#5351](#5351)) ([d5d6766](d5d6766)), closes [#5336](#5336) * Revert "fix: Update milvus connect function to work with remote instance" ([#5398](#5398)) ([434dd92](434dd92)), closes [#5382](#5382)

# [0.50.0](v0.49.0...v0.50.0) (2025-07-01) ### Bug Fixes * Add asyncio to integration test ([#5418](#5418)) ([6765515](6765515)) * Add clickhouse to OFFLINE_STORE_CLASS_FOR_TYPE map ([#5251](#5251)) ([9ed2ffa](9ed2ffa)) * Add missing conn.commit() in SnowflakeOnlineStore.online_write_batch ([#5432](#5432)) ([a83dd85](a83dd85)) * Add transformers in required dependencies ([8cde460](8cde460)) * Allow custom annotations on Operator installed objects ([#5339](#5339)) ([44c7a76](44c7a76)) * Dask pulling of latest data ([#5229](#5229)) ([571d81f](571d81f)) * **dask:** preserve remote URIs (e.g. s3://) in DaskOfflineStore path resolution ([2561cfc](2561cfc)) * Fix Event loop is closed error on dynamodb test ([#5480](#5480)) ([fe0f671](fe0f671)) * Fix lineage entity filtering ([#5321](#5321)) ([0d05701](0d05701)) * Fix list saved dataset api ([833696c](833696c)) * Fix NumPy - PyArrow array type mapping in Trino offline store ([#5393](#5393)) ([9ba9ded](9ba9ded)) * Fix pandas 2.x compatibility issue of Trino offline store caused by removed Series.iteritems() method ([#5345](#5345)) ([61e3e02](61e3e02)) * Fix polling mechanism for TestApplyAndMaterialize ([#5451](#5451)) ([b512a74](b512a74)) * Fix remote rbac integration tests ([#5473](#5473)) ([10879ec](10879ec)) * Fix Trino offline store SQL in Jinja template ([#5346](#5346)) ([648c53d](648c53d)) * Fixed CurlGeneratorTab github theme type ([#5425](#5425)) ([5f15329](5f15329)) * Increase the Operator Manager memory limits and requests ([#5441](#5441)) ([6c94dbf](6c94dbf)) * Method signature for push_async is out of date ([#5413](#5413)) ([28c3379](28c3379)), closes [#5410](#5410) [#006BB4](https://github.com/feast-dev/feast/issues/006BB4) * Operator - support securityContext override at Pod level ([#5325](#5325)) ([33ea0f5](33ea0f5)) * Pybuild-deps throws errors w/ latest pip version ([#5311](#5311)) ([f2d6a67](f2d6a67)) * Reopen for integration test about add s3 storage-based registry store in Go feature server ([#5352](#5352)) ([ef75f61](ef75f61)) * resolve Python logger warnings ([#5361](#5361)) ([37d5c19](37d5c19)) * The ignore_paths not taking effect duration feast apply ([#5353](#5353)) ([e4917ca](e4917ca)) * Update generate_answer function to provide correct parameter format to retrieve function ([dc5b2af](dc5b2af)) * Update milvus connect function to work with remote instance ([#5382](#5382)) ([7e5e7d5](7e5e7d5)) * Updating milvus connect function to work with remote instance ([#5401](#5401)) ([b89fadd](b89fadd)) * Upperbound limit for protobuf generation ([#5309](#5309)) ([a114aae](a114aae)) ### Features * Add CLI, SDK, and API documentation page to Feast UI ([#5337](#5337)) ([203e888](203e888)) * Add dark mode toggle to Feast UI ([#5314](#5314)) ([ad02e46](ad02e46)) * Add data labeling tabs to UI ([#5410](#5410)) ([389ceb7](389ceb7)), closes [#006BB4](https://github.com/feast-dev/feast/issues/006BB4) * Add Decimal to allowed python scalar types ([#5367](#5367)) ([4777c03](4777c03)) * Add feast rag retriver functionality ([#5405](#5405)) ([0173033](0173033)) * Add feature view curl generator ([#5415](#5415)) ([7a5b48f](7a5b48f)) * Add feature view lineage tab and filtering to home page lineage ([#5308](#5308)) ([308255d](308255d)) * Add feature view tags to dynamo tags ([#5291](#5291)) ([3a787ac](3a787ac)) * Add HybridOnlineStore for multi-backend online store routing ([#5423](#5423)) ([ebd67d1](ebd67d1)) * Add max_file_size to Snowflake config ([#5377](#5377)) ([e8cdf5d](e8cdf5d)) * Add MCP (Model Context Protocol) support for Feast feature server ([#5406](#5406)) ([de650de](de650de)), closes [#5398](#5398) [#5382](#5382) [#5389](#5389) [#5401](#5401) * Add rag project to default dev UI ([#5323](#5323)) ([3b3e1c8](3b3e1c8)) * Add s3 storage-based registry store in Go feature server ([#5336](#5336)) ([abe18df](abe18df)) * Add support for data labeling in UI ([#5409](#5409)) ([d183c4b](d183c4b)), closes [#27](#27) * Added Lineage APIs to get registry objects relationships ([#5472](#5472)) ([be004ef](be004ef)) * Added rest-apis serving option for registry server ([#5342](#5342)) ([9740fd1](9740fd1)) * Added torch.Tensor as option for online and offline retrieval ([#5381](#5381)) ([0b4ae95](0b4ae95)) * Adding feast delete to CLI ([#5344](#5344)) ([19fe3ac](19fe3ac)) * Adding permissions to UI and refactoring some things ([#5320](#5320)) ([6f1b0cc](6f1b0cc)) * Allow to set registry server rest/grpc mode in operator ([#5364](#5364)) ([99afd6d](99afd6d)) * Allow to use env variable FEAST_FS_YAML_FILE_PATH and FEATURE_REPO_DIR ([#5420](#5420)) ([6a1b33a](6a1b33a)) * Enable materialization for ODFV Transform on Write ([#5459](#5459)) ([3d17892](3d17892)) * Improve search results formatting ([#5326](#5326)) ([18cbd7f](18cbd7f)) * Improvements to Lambda materialization engine ([#5379](#5379)) ([b486f29](b486f29)) * Make batch_source optional in PushSource ([#5440](#5440)) ([#5454](#5454)) ([ae7e20e](ae7e20e)) * Refactor materialization engine ([#5354](#5354)) ([f5c5360](f5c5360)) * Remote Write to Online Store completes client / server architecture ([#5422](#5422)) ([2368f42](2368f42)) * Serialization version 2 and below removed ([#5435](#5435)) ([9e50e18](9e50e18)) * SQLite online retrieval. Add timezone info into timestamp. ([#5386](#5386)) ([6b05153](6b05153)) * Support dual-mode REST and gRPC for Feast Registry Server ([#5396](#5396)) ([fd1f448](fd1f448)) * Support DynamoDB as online store in Go feature server ([#5464](#5464)) ([40d25c6](40d25c6)) * Update Spark Compute read source node to be able to use other data sources ([#5445](#5445)) ([a93d300](a93d300)) ### Reverts * Chore Release "chore(release): release 0.50.0" ([#5483](#5483)) ([0eef391](0eef391)) * Feat: Add CLI, SDK, and API documentation page to Feast UI" ([#5341](#5341)) ([b492f14](b492f14)), closes [#5337](#5337) * Revert "feat: Add s3 storage-based registry store in Go feature server" ([#5351](#5351)) ([d5d6766](d5d6766)), closes [#5336](#5336) * Revert "fix: Update milvus connect function to work with remote instance" ([#5398](#5398)) ([434dd92](434dd92)), closes [#5382](#5382)

ntkathole requested a review from a team as a code owner May 17, 2025 17:07

tchughesiv requested changes May 17, 2025

View reviewed changes

infra/feast-operator/api/v1alpha1/featurestore_types.go Outdated Show resolved Hide resolved

tchughesiv reviewed May 17, 2025

View reviewed changes

ntkathole force-pushed the move_ui_rest branch 3 times, most recently from 33d6450 to 1108633 Compare May 18, 2025 05:32

ntkathole force-pushed the move_ui_rest branch from 1108633 to ca639fe Compare May 18, 2025 05:41

ntkathole closed this May 18, 2025

ntkathole force-pushed the move_ui_rest branch from ca639fe to 648c53d Compare May 18, 2025 06:10

ntkathole reopened this May 18, 2025

ntkathole requested a review from tchughesiv May 18, 2025 06:23

tchughesiv requested changes May 18, 2025

View reviewed changes

infra/feast-operator/api/v1alpha1/featurestore_types.go Outdated Show resolved Hide resolved

infra/feast-operator/internal/controller/services/services.go Outdated Show resolved Hide resolved

infra/feast-operator/internal/controller/services/services.go Outdated Show resolved Hide resolved

tchughesiv added the ok-to-test label May 18, 2025

tchughesiv requested changes May 18, 2025

View reviewed changes

ntkathole force-pushed the move_ui_rest branch 5 times, most recently from ea9f800 to 75dcc2d Compare May 21, 2025 11:06

tchughesiv reviewed May 21, 2025

View reviewed changes

infra/feast-operator/internal/controller/featurestore_controller_test.go Outdated Show resolved Hide resolved

ntkathole force-pushed the move_ui_rest branch 3 times, most recently from d42d9e5 to 4953754 Compare May 22, 2025 04:32

ntkathole requested a review from tchughesiv May 22, 2025 05:53

tchughesiv requested changes May 22, 2025

View reviewed changes

tchughesiv added the do-not-merge/hold label May 22, 2025

feat: Allow to set registry server rest/grpc mode in operator

e67fc0d

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

tchughesiv requested changes Jun 11, 2025

View reviewed changes

tchughesiv removed the do-not-merge/hold label Jun 11, 2025

ntkathole and others added 3 commits June 11, 2025 20:55

Apply suggestions from code review

4e06343

Co-authored-by: Tommy Hughes IV <tchughesiv@gmail.com> Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

fix: Created GetFeastRestServiceName method

e28a578

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

fix: Refactor createRestService to reuse setService

63af9da

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

ntkathole force-pushed the move_ui_rest branch from 89a2418 to 63af9da Compare June 11, 2025 15:27

tchughesiv requested changes Jun 11, 2025

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Outdated Show resolved Hide resolved

infra/feast-operator/internal/controller/services/services.go Outdated Show resolved Hide resolved

ntkathole added 3 commits June 12, 2025 10:35

fix: Handle service and port on grpc disable

dc176ba

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

feat: Added isRegistryRestEnabled and isRegistryGrpcEnabled methods

9785b9d

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

fix: Fixed rest server port

f231f0d

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

tchughesiv reviewed Jun 12, 2025

View reviewed changes

sdk/python/feast/cli/serve.py Show resolved Hide resolved

tchughesiv requested changes Jun 12, 2025

View reviewed changes

tchughesiv reviewed Jun 12, 2025

View reviewed changes

infra/feast-operator/api/v1alpha1/featurestore_types.go Outdated Show resolved Hide resolved

tchughesiv requested changes Jun 12, 2025

View reviewed changes

fix: Changes as per comments

68480ab

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

tchughesiv requested changes Jun 13, 2025

View reviewed changes

infra/feast-operator/api/v1alpha1/featurestore_types.go Show resolved Hide resolved

fix: Handle tls mount for rest server

d73e524

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

tchughesiv requested changes Jun 13, 2025

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Show resolved Hide resolved

tchughesiv reviewed Jun 13, 2025

View reviewed changes

infra/feast-operator/internal/controller/services/services.go Show resolved Hide resolved

tchughesiv reviewed Jun 13, 2025

View reviewed changes

infra/feast-operator/test/api/featurestore_types_test.go Outdated Show resolved Hide resolved

ntkathole added 2 commits June 13, 2025 21:35

test: Added tests for field validations

6ace5ec

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

test: Added tests for svc probe, container port and registry validations

8c649c2

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>

ntkathole force-pushed the move_ui_rest branch from 5b3dd49 to 8c649c2 Compare June 13, 2025 16:36

tchughesiv approved these changes Jun 13, 2025

View reviewed changes

tchughesiv merged commit 99afd6d into feast-dev:master Jun 13, 2025
19 checks passed

	func (feast *FeastServices) setRemoteRegistryURL() error {
	if feast.isRemoteHostnameRegistry() {
	feast.Handler.FeatureStore.Status.ServiceHostnames.Registry = *feast.Handler.FeatureStore.Status.Applied.Services.Registry.Remote.Hostname
	} else if feast.IsRemoteRefRegistry() {
	remoteFeast, err := feast.getRemoteRegistryFeastHandler()
	if err != nil {
	return err
	}
	// referenced/remote registry must use the local registry server option and be in a 'Ready' state.
	if remoteFeast != nil &&
	remoteFeast.isRegistryServer() &&
	apimeta.IsStatusConditionTrue(remoteFeast.Handler.FeatureStore.Status.Conditions, feastdevv1alpha1.RegistryReadyType) &&
	len(remoteFeast.Handler.FeatureStore.Status.ServiceHostnames.Registry) > 0 {
	feast.Handler.FeatureStore.Status.ServiceHostnames.Registry = remoteFeast.Handler.FeatureStore.Status.ServiceHostnames.Registry
	} else {
	return errors.New("Remote feast registry of referenced FeatureStore '" + remoteFeast.Handler.FeatureStore.Name + "' is not ready")
	}
	}
	return nil
	}


	isRegistry := feastType == RegistryFeastType && feast.isRegistryServer()

	grpcEnabled := !feast.isRegistryServer() \|\| feast.isRegistryGrpcEnabled()
	if grpcEnabled {
	container.Ports = append(container.Ports, corev1.ContainerPort{
	Name: name,
	ContainerPort: getTargetPort(feastType, tls),
	Protocol: corev1.ProtocolTCP,
	})
	}

	if isRegistry && feast.isRegistryRestEnabled() {
	container.Ports = append(container.Ports, corev1.ContainerPort{
	Name: name + "-rest",
	ContainerPort: getTargetRestPort(feastType, tls),
	Protocol: corev1.ProtocolTCP,
	})
	}

feat: Allow to set registry server rest/grpc mode in operator #5364

feat: Allow to set registry server rest/grpc mode in operator #5364

Conversation

ntkathole commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Uh oh!

Uh oh!

tchughesiv left a comment

Choose a reason for hiding this comment

Uh oh!

ntkathole commented May 18, 2025

Uh oh!

tchughesiv left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tchughesiv left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tchughesiv left a comment

Choose a reason for hiding this comment

Uh oh!

ntkathole commented May 22, 2025

Uh oh!

tchughesiv commented May 22, 2025

Uh oh!

ntkathole commented Jun 11, 2025

Uh oh!

ntkathole commented Jun 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tchughesiv commented Jun 11, 2025

Uh oh!

tchughesiv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tchughesiv left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tchughesiv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tchughesiv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ntkathole commented May 17, 2025 •

edited

Loading

tchughesiv left a comment •

edited

Loading

tchughesiv left a comment •

edited

Loading

tchughesiv left a comment •

edited

Loading