Add --miss-cache flag to dnsping #92
Conversation
| dns.flags.to_text(query.flags)), flush=True) | ||
| print("%s DNS: %s:%d, hostname: %s, force_miss: %s, proto: %s, rdatatype: %s, flags: %s" % | ||
| (__progname__, dnsserver, dst_port, qname, force_miss, proto_to_text(proto), rdatatype, | ||
| dns.flags.to_text(dns.flags.RD)), flush=True) |
There was a problem hiding this comment.
I'm not sure how the flags here should be done. Initially I kept the code between line 200 and 207 to create a "dummy request" that I could then use for dns.flags.to_text(dummyquery.flags) but that didn't feel very nice. So I tried to see which of the options would actually change the flags from RD, but couldn't see or think of any case that this would happen?
Tried to look at what make_query does https://github.com/rthalley/dnspython/blob/v2.1.0/dns/message.py#L1433
and also tried the options for dnsping to see if any of them changed the outgoing flags, but couldn't see it. If there is an option that changes this, please let me know.
| @@ -219,6 +215,19 @@ def main(): | |||
| else: | |||
| i += 1 | |||
|
|
|||
| if force_miss: | |||
There was a problem hiding this comment.
This code is very obviously mirroring https://github.com/farrokhi/dnsdiag/blob/94d6e48/util/dns.py#L102-L111
|
Thanks. I need to refactor this a bit before merging. It will be merged in v2.1.0 |
I felt like it would be helpful to have a
miss-cacheoption for thednspingjust like fordnseval.This PR adds an option using the exact same syntax and mechanics as the same option for
dnseval, to offer more flexibility to dnsdiag.