Improve energy efficiency by applying Dynamic Retry Delay Energy Pattern + Cache Energy Pattern #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmerbb
reviewed
Jul 23, 2020
| if (lastbundle.equals(intent.getBundleExtra(com.twofortyfouram.locale.api.Intent.EXTRA_BUNDLE))) { | ||
| return; | ||
| } | ||
| updateValues(intent); | ||
| if(U.isExternalAccessDisabled(context)) return; |
There was a problem hiding this comment.
This line should be moved above the four lines that are newly added. If the external access pref is disabled then the receiver should not run anything, period.
|
Thanks for your contribution. SecondScreen does not access the network whatsoever - it doesn't even declare I am happy to accept the changes to the |
|
SecondScreen's sister app, Taskbar, also has a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the energy efficiency of SecondScreen by applying the Dynamic Retry Delay Energy Pattern and the Cache Energy Pattern for mobile applications.
The energy pattern was applied in SecondScreenIntentService.java and AndroidManifest.xml (for the Dynamic Retry Delay Energy Pattern) and TaskerConditionReceiver.java (for the Cache Energy Pattern). The general idea for the first one is to avoid accessing an internet connection if the connection is down . In particular, a class NetworkStateReceiver will be created in the java file that checks for an internet connection. The general idea for the second one is to avoid performing unnecessary operations by using cache mechanisms. In particular, the operations in method onReceive will only execute if the bundles changes.