Skip to content

Conversation

kushalkolar
Copy link
Member

No description provided.

@kushalkolar kushalkolar requested a review from clewis7 as a code owner January 28, 2025 01:11
Copy link

github-actions bot commented Jan 28, 2025

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/bump-v0.4.0

@kushalkolar
Copy link
Member Author

kushalkolar commented Feb 5, 2025

For some reason the cmap is wrapping around for the histogram colorbar on github actions, this isn't happening locally on my computer :/ . I'm on latest pygfx@main and wgpu

The place the arrow is pointing to should be black:

image

@kushalkolar
Copy link
Member Author

ok something weird going on with texture cmap wrapping, the background in the "selected" subplot is supposed to be dark blue/purple for low value in viridis: https://www.fastplotlib.org/ver/bump-v0.4.0/_gallery/selection_tools/fft.html#sphx-glr-gallery-selection-tools-fft-py

@kushalkolar
Copy link
Member Author

posted at pygfx/pygfx#979

@kushalkolar
Copy link
Member Author

@clewis7 I say let's merge in the meantime?

@clewis7 clewis7 merged commit 6c967a8 into main Feb 13, 2025
37 of 52 checks passed
@clewis7 clewis7 deleted the bump-v0.4.0 branch February 13, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants