Skip to content

Lazy import av #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2024
Merged

Lazy import av #432

merged 1 commit into from
Mar 14, 2024

Conversation

almarklein
Copy link
Collaborator

After #431 I did a review of all imports. I found 2 small interesting cases, which are addressed in this PR:

  • One absolute import of a fastplotlib module.
  • The optional dependency av can easily be lazy-imported (shaving nearly 0.1 off the import time on my machine).

kushalkolar
kushalkolar reviewed Mar 13, 2024
View reviewed changes
@almarklein almarklein marked this pull request as ready for review March 14, 2024 08:28
@kushalkolar kushalkolar merged commit fe74179 into fastplotlib:main Mar 14, 2024
@almarklein almarklein deleted the av branch March 15, 2024 08:04
@kushalkolar kushalkolar mentioned this pull request Apr 9, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushalkolar kushalkolar kushalkolar left review comments

+1 more reviewer

@EricThomson EricThomson EricThomson left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@almarklein @EricThomson @kushalkolar