Skip to content

add desktop-only CI, add py312, remove ipywidgets import in plot.py, pin pygfx>=0.1.14 #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2023
Merged

add desktop-only CI, add py312, remove ipywidgets import in plot.py, pin pygfx>=0.1.14 #314

merged 3 commits into from
Oct 3, 2023

Conversation

kushalkolar
Copy link
Member

  1. This adds CI to test that the examples work in an environment without jupyter and ipywidgets, to make sure that the examples work in a "minimal" env with only glfw.
  2. Add python 3.12 to CI
  3. remove ipywidgets import from layouters/_plot.py
  4. pin pygfx>=0.1.14

@kushalkolar kushalkolar requested a review from clewis7 October 3, 2023 18:45
clewis7
clewis7 reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@clewis7 clewis7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@kushalkolar kushalkolar merged commit 3965bb1 into master Oct 3, 2023
@kushalkolar kushalkolar deleted the ci-tweaks branch October 3, 2023 20:43
@kushalkolar kushalkolar mentioned this pull request Oct 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clewis7 clewis7 clewis7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kushalkolar @clewis7