Skip to content

More interaction #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 8, 2023
Merged

More interaction #106

merged 3 commits into from
Jan 8, 2023

Conversation

kushalkolar
Copy link
Member

  • bugfix for handling feature events if the event handlers are methods instead of functions
  • bugfix, image has cmap and not colors for feature_events class attr
  • Graphic.link() can be bidirectional using kwarg bidirectional=True
    • Basically if bidirectional=True, Graphic.link() does target.link() with the same arguments. target.link() uses bidirectional=False to prevent infinite recursion.
    • _set_feature() exits (just returns) if the previous_data.indices is identical to the new indices, this was also necessary to prevent infinite recurusion.
    • allow 1D numpy arrays for indexing GraphicCollection

@kushalkolar kushalkolar merged commit 4a64391 into master Jan 8, 2023
@kushalkolar kushalkolar mentioned this pull request Jan 9, 2023
Closed
3 tasks
@kushalkolar kushalkolar deleted the more-interaction branch January 9, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kushalkolar