Skip to content

feat(domainmanagement): Adds support for domain-management/v1/domains endpoints #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 12, 2025
Merged

feat(domainmanagement): Adds support for domain-management/v1/domains endpoints #726

merged 4 commits into from
Aug 12, 2025

Conversation

nsmethwick-fastly
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Updates UDM routes to use new /domain-management/v1/domains API endpoints instead of /domains/v1. Renames/Reorganizes domains/v1 files to follow new structure as well

@nsmethwick-fastly nsmethwick-fastly requested a review from a team as a code owner August 1, 2025 20:07
gschorkopf
gschorkopf approved these changes Aug 4, 2025
View reviewed changes
Copy link
Member

@gschorkopf gschorkopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks accurate to me, but I'll let others weigh in

kpfleming
kpfleming requested changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a CHANGELOG entry although it doesn't have to be marked as breaking since this product is still in beta.

The TestClient_Domain test failed, that will need to be corrected.

@Integralist Integralist force-pushed the noah/appeng-10561 branch 2 times, most recently from 97c02fe to f8a9dec Compare August 7, 2025 11:11
@Integralist Integralist requested a review from kpfleming August 7, 2025 11:19
kpfleming
kpfleming approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go - however we won't be able to upgrade the CLI to go-fastly version 11.x until some context related work is done there first. I will try to work on that today.

@Integralist
Copy link
Collaborator

@kpfleming I see the CLI PR for updating to go-fastly v11.x has been completed. So I'm guessing this PR is safe to merge now?

@kpfleming
Copy link
Contributor

It was safe to merge before that too :-)

@kpfleming kpfleming merged commit 411d098 into main Aug 12, 2025
7 checks passed
@kpfleming kpfleming deleted the noah/appeng-10561 branch August 12, 2025 11:16
@Integralist
Copy link
Collaborator

Integralist commented Aug 12, 2025 •
edited
Loading

Thanks @kpfleming when is the next release cycle for go-fastly expected?

@Integralist
Copy link
Collaborator

Ah, I see from the README...

On the first Wednesday of each month

Damn, I just missed a release 😅

@kpfleming
Copy link
Contributor

There will probably be one fairly soon, as some 'fast follow' work for the Security API is in flight right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpfleming kpfleming kpfleming approved these changes

@gschorkopf gschorkopf gschorkopf approved these changes

@Integralist Integralist Awaiting requested review from Integralist

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nsmethwick-fastly @Integralist @kpfleming @gschorkopf