Skip to content

Combine workspace and account rules #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 17, 2025
Merged

Combine workspace and account rules #721

merged 10 commits into from
Jul 17, 2025

Conversation

philippschulte
Copy link
Member

@philippschulte philippschulte commented Jul 15, 2025 •
edited by anthony-gomez-fastly
Loading

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Does not pass test yet!

Are there any considerations that need to be addressed for release?

This is a breaking change!

Notes for reviewers

The goal is to use one implementation for both account and workspace level rules. The same pattern can be applied for lists and signals. The necessary tooling is provided in this PR!

This PR should make it very do adopt the same pattern for lists and signals:

  • remove all WorkspaceID fields from the input structs
  • add common.scope to all input structs (the workspaceID needs to be added to the applies_to field inside the scope struct
  • use common.pathbuilder() to set the proper path in each request function
  • wrap the current test suite inside another a function which then gets call for a scope of "workspace" and "account"

@philippschulte philippschulte requested a review from a team as a code owner July 15, 2025 17:13
anthony-gomez-fastly
anthony-gomez-fastly reviewed Jul 15, 2025
View reviewed changes
anthony-gomez-fastly
anthony-gomez-fastly reviewed Jul 15, 2025
View reviewed changes
anthony-gomez-fastly
anthony-gomez-fastly approved these changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the tests pass! ty!!

@philippschulte
Copy link
Member Author

The rules test suite fails because scope type of "account" doesn't like the same config as with scope type of "workspace":

--- FAIL: TestClient_Rule_AccountScope (0.00s)
    api_test.go:191: 400 - Bad Request:
        
            Title:  The request does not validate or is improperly formed
            Detail: Validation failed - corp rules cannot use custom responses

anthony-gomez-fastly
anthony-gomez-fastly reviewed Jul 15, 2025
View reviewed changes
anthony-gomez-fastly
anthony-gomez-fastly reviewed Jul 15, 2025
View reviewed changes
@anthony-gomez-fastly anthony-gomez-fastly mentioned this pull request Jul 16, 2025
Merged
6 tasks
@philippschulte philippschulte merged commit ca69c9b into fastly:main Jul 17, 2025
4 checks passed
@philippschulte philippschulte deleted the pschulte/combine-workspace-and-account-rules branch July 17, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-gomez-fastly anthony-gomez-fastly anthony-gomez-fastly approved these changes

Assignees

@anthony-gomez-fastly anthony-gomez-fastly

Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippschulte @anthony-gomez-fastly