BREAKING: Implement full support for Go 'context.Context' #717
+3,111
−3,861
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces full support for Go context.Context objects, following best practices documented by the Go community.
All exported functions which can generate HTTP requests now require a context.Context object as their first parameter; the 'ctx' fields in Input structures (used in previous versions of go-fastly) have been removed. The provided context will be used for all HTTP requests generated by the function.
If the application using go-fastly does not have existing context.Context objects of its own, then context.TODO() can be passed to the go-fastly functions.
All Submissions:
New Feature Submissions:
Changes to Core Features:
User Impact
This is a major breaking change and will require a version-bump of the module, as well as a forum post and other types of outbound communication.