[CDTOOL-1056] Implement new mechanism for serializing mutating requests. #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new method ensures that mutating requests being issued by separate Client objects are serialized, which will resolve issues with applications which use multiple Client objects in goroutines. The default mode serializes all mutating requests, but the mechanism offers a way to group requests by a 'resource ID' to minimize the performance impact.
cee-dub
requested changes
Jul 10, 2025
|
This should work even if clients don't opt-in to it, because there's a default 'resource ID' which will capture all mutating operations. Opting in is only necessary to improve performance by allowing mutating operations for separate resources to happen in parallel. |
cee-dub
approved these changes
Jul 11, 2025
philippschulte
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new method ensures that mutating requests being issued by separate Client objects are serialized, which will resolve issues with applications which use multiple Client objects in goroutines.
The default mode serializes all mutating requests, but the mechanism offers a way to group requests by a 'resource ID' to minimize the performance impact.
All Submissions:
New Feature Submissions:
Changes to Core Features:
User Impact
Are there any considerations that need to be addressed for release?