Skip to content

fix(ngwaf/v1/workspaces/redactions): remove mode and page params and remove requirement for both field and type for update #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 10, 2025
Merged

fix(ngwaf/v1/workspaces/redactions): remove mode and page params and remove requirement for both field and type for update #712

merged 4 commits into from
Jul 10, 2025

Conversation

anthony-gomez-fastly
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly commented Jul 8, 2025 •
edited by philippschulte
Loading

Fix for #710.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

@anthony-gomez-fastly
fix(ngwaf/v1/workspaces/redactions): remove mode and page params and …
a9ee0f2 
…remove requirement for both field and type for update

BREAKING CHANGE:
@anthony-gomez-fastly anthony-gomez-fastly linked an issue Jul 8, 2025 that may be closed by this pull request
NGWAF Redactions Client #710
Closed
@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review July 8, 2025 14:58
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner July 8, 2025 14:58
kpfleming
kpfleming reviewed Jul 8, 2025
View reviewed changes
philippschulte
philippschulte approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anthony-gomez-fastly anthony-gomez-fastly merged commit c102d0b into main Jul 10, 2025
7 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the issue-710 branch July 10, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippschulte philippschulte philippschulte approved these changes

@kpfleming kpfleming Awaiting requested review from kpfleming

Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NGWAF Redactions Client
3 participants
@anthony-gomez-fastly @kpfleming @philippschulte