Skip to content

fix(ngwaf/v1/workpsaces/requests): add missing field to metadata struct and update documentation around limits #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 8, 2025
Merged

fix(ngwaf/v1/workpsaces/requests): add missing field to metadata struct and update documentation around limits #711

merged 5 commits into from
Jul 8, 2025

Conversation

anthony-gomez-fastly
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly commented Jul 8, 2025 •
edited by philippschulte
Loading

Fix for #709.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

@anthony-gomez-fastly anthony-gomez-fastly linked an issue Jul 8, 2025 that may be closed by this pull request
NGWAF Request Client #709
Closed
@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review July 8, 2025 14:14
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner July 8, 2025 14:14
philippschulte
philippschulte previously requested changes Jul 8, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes but you still require limit with ErrMissingLimit. Please test this yourself to make sure that limit is really not required.

philippschulte
philippschulte approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anthony-gomez-fastly anthony-gomez-fastly merged commit e3d777b into main Jul 8, 2025
7 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the issue-709 branch July 8, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippschulte philippschulte philippschulte approved these changes

Assignees

@philippschulte philippschulte

Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NGWAF Request Client
2 participants
@anthony-gomez-fastly @philippschulte