Skip to content

Address various issues in NGWAF API. #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2025
Merged

Address various issues in NGWAF API. #705

merged 3 commits into from
Jun 30, 2025

Conversation

kpfleming
Copy link
Contributor

@kpfleming kpfleming commented Jun 29, 2025 •
edited
Loading

  • Ensure that all optional fields in Input structures are annotated with 'omitempty'.

  • Do not require 'Conditions' to be provided in rules.Update.

  • Ensure that test for workspaces.Update modifies as many attributes as possible.

  • Test for missing 'Mode' in workspaces.Create.

  • Run all NGWAF API tests against 'de2' CID.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

kpfleming
kpfleming commented Jun 29, 2025
View reviewed changes
@kpfleming kpfleming force-pushed the fix-ngwaf-problems branch 3 times, most recently from 6a74405 to 32e480a Compare June 29, 2025 13:18
@kpfleming kpfleming requested a review from philippschulte June 29, 2025 13:19
@kpfleming kpfleming force-pushed the fix-ngwaf-problems branch from 32e480a to 50a5029 Compare June 29, 2025 15:31
@kpfleming kpfleming marked this pull request as ready for review June 29, 2025 15:32
@kpfleming kpfleming requested a review from a team as a code owner June 29, 2025 15:32
@kpfleming
Address various issues in NGWAF API.
4924c23 
* Ensure that all optional fields in Input structures are annotated
  with 'omitempty'.

* Do not require 'Conditions' to be provided in rules.Update.

* Ensure that test for workspaces.Update modifies as many attributes
  as possible.

* Test for missing 'Mode' in workspaces.Create.

* Run all NGWAF API tests against 'de2' CID.
@kpfleming kpfleming force-pushed the fix-ngwaf-problems branch from 50a5029 to 4924c23 Compare June 30, 2025 15:13
philippschulte
philippschulte requested changes Jun 30, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting the ngwaf api. The only thing I found is that we don't need omitempty for actions in rules create.

@kpfleming kpfleming merged commit f560c15 into fastly:main Jun 30, 2025
4 checks passed
@kpfleming kpfleming deleted the fix-ngwaf-problems branch June 30, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippschulte philippschulte philippschulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpfleming @philippschulte