Skip to content

Add missing fields to ngwaf workspaces endpoints #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 24, 2025
Merged

Add missing fields to ngwaf workspaces endpoints #701

merged 3 commits into from
Jun 24, 2025

Conversation

philippschulte
Copy link
Member

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

The security team added the following fields to to the ngwaf workspaces endpoints after #679 was introduced and merged:

  • client_ip_headers
  • default_blocking_response_code

@philippschulte philippschulte requested a review from a team as a code owner June 23, 2025 20:52
philippschulte
philippschulte commented Jun 23, 2025
View reviewed changes
philippschulte
philippschulte commented Jun 23, 2025
View reviewed changes
anthony-gomez-fastly
anthony-gomez-fastly approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@philippschulte philippschulte merged commit 1a634df into fastly:main Jun 24, 2025
4 checks passed
@philippschulte philippschulte deleted the pschulte/add-missing-fields-to-ngwaf-workspaces-endpoints branch June 24, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-gomez-fastly anthony-gomez-fastly anthony-gomez-fastly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippschulte @anthony-gomez-fastly