Skip to content

[CDTOOL-1089] Add support for ngwaf lists #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

[CDTOOL-1089] Add support for ngwaf lists #700

merged 1 commit into from
Jun 24, 2025

Conversation

anthony-gomez-fastly
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1089-workspace-lists branch from 1238541 to f158cba Compare June 23, 2025 18:58
@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1089-workspace-lists branch from f158cba to 8ccc490 Compare June 23, 2025 18:58
@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review June 23, 2025 18:58
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner June 23, 2025 18:58
@philippschulte philippschulte changed the title feat(ngwaf): addds CRUD functionality for NGWAF lists [CDTOOL-1089] Add support for ngwaf lists Jun 24, 2025
philippschulte
philippschulte reviewed Jun 24, 2025
View reviewed changes
philippschulte
philippschulte approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We need to discuss as a team how we define slices because we have inconsistencies in the entire code base.

@philippschulte philippschulte merged commit 437eb07 into main Jun 24, 2025
7 checks passed
@philippschulte philippschulte deleted the CDTOOL-1089-workspace-lists branch June 24, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippschulte philippschulte philippschulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthony-gomez-fastly @philippschulte