Skip to content

Conversation

joeshaw
Copy link
Member

@joeshaw joeshaw commented Jun 20, 2025

This matches behavior on the Secret Store and Config Store list
endpoints.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@joeshaw joeshaw marked this pull request as ready for review June 23, 2025 14:56
@joeshaw joeshaw requested a review from a team as a code owner June 23, 2025 14:56
@joeshaw
Copy link
Member Author

joeshaw commented Jun 23, 2025

The new parameter has been deployed to production, so I've switched this off of draft status.

@anthony-gomez-fastly
Copy link
Contributor

@joeshaw mind adding a test for this? if you can't generate the fixture i'm happy to do so once the test is in

@joeshaw
Copy link
Member Author

joeshaw commented Jun 23, 2025

@anthony-gomez-fastly Just pushed a commit with a test. Please generate the fixture!

Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for this! @kpfleming any thoughts before we merge?

@philippschulte philippschulte merged commit 7b93b5b into main Jun 24, 2025
7 checks passed
@philippschulte philippschulte deleted the joeshaw/kv-store-by-name branch June 24, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants