Skip to content

[CDTOOL-1052] Add support for ngwaf rules #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 23, 2025
Merged

[CDTOOL-1052] Add support for ngwaf rules #691

merged 10 commits into from
Jun 23, 2025

Conversation

philippschulte
Copy link
Member

@philippschulte philippschulte commented Jun 9, 2025 •
edited
Loading

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

@philippschulte philippschulte added the enhancement New feature or request label Jun 9, 2025
@philippschulte
Copy link
Member Author

Test suite is failing because of the update request:

--- FAIL: TestClient_Rule (2.52s)
    api_test.go:445: 
        	Error Trace:	/home/philipp/src/fastly/go-fastly/fastly/ngwaf/v1/rules/api_test.go:445
        	Error:      	Not equal: 
        	           	expected: "https://updated.com"
        	           	actual  : ""
        	           	
        	           	Diff:
        	           	--- Expected
        	           	+++ Actual
        	           	@@ -1 +1 @@
        	           	-https://updated.com
        	           	+
        	Test:       	TestClient_Rule
FAIL
FAIL	github.com/fastly/go-fastly/v10/fastly/ngwaf/v1/rules	2.530s

The API doesn't update the new value for the redirect_url!

@philippschulte philippschulte marked this pull request as ready for review June 9, 2025 17:30
@philippschulte philippschulte requested a review from a team as a code owner June 9, 2025 17:30
stevebartell
stevebartell reviewed Jun 10, 2025
View reviewed changes
kpfleming
kpfleming requested changes Jun 18, 2025
View reviewed changes
anthony-gomez-fastly
anthony-gomez-fastly approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is excellent, thank you so much for doing all this ❤️ and being so thorough

@philippschulte philippschulte merged commit cc2bfbc into fastly:main Jun 23, 2025
4 checks passed
@philippschulte philippschulte deleted the pschulte/CDTOOL-1052_add-support-for-rules-api branch June 23, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevebartell stevebartell stevebartell left review comments

@kpfleming kpfleming kpfleming approved these changes

@anthony-gomez-fastly anthony-gomez-fastly anthony-gomez-fastly approved these changes

@rcaril rcaril Awaiting requested review from rcaril

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philippschulte @kpfleming @stevebartell @anthony-gomez-fastly