Skip to content

CDTOOL-1053] Support for NGWAF Time Series #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 5, 2025
Merged

CDTOOL-1053] Support for NGWAF Time Series #689

merged 4 commits into from
Jun 5, 2025

Conversation

rcaril
Copy link
Contributor

@rcaril rcaril commented Jun 5, 2025 •
edited
Loading

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Are there any considerations that need to be addressed for release?

  • Removed unneeded code in the api_resp.go file for Virutal Patches

@rcaril
Timeseries support
a2ae2ac 
- Added support for NGWAF timeseries
- Removed unneeded  code in the api_resp file for virtualpatches
@rcaril rcaril requested a review from a team as a code owner June 5, 2025 19:41
@rcaril rcaril requested a review from philippschulte June 5, 2025 19:41
@anthony-gomez-fastly
Copy link
Contributor

once the lint/fmt/test stuff gets ironed out looks good

philippschulte
philippschulte requested changes Jun 5, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! You just need to update the test suite by using a fixed start and end time.

@rcaril rcaril changed the title CDTOOL-1053] Support-for-NGWAF-Time-Series CDTOOL-1053] Support for NGWAF Time Series Jun 5, 2025
@rcaril rcaril requested a review from philippschulte June 5, 2025 20:47
philippschulte
philippschulte approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rcaril rcaril merged commit 1a29148 into main Jun 5, 2025
7 checks passed
@rcaril rcaril deleted the CDTOOL-1053]-Support-for-NGWAF-Time-Series branch June 5, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippschulte philippschulte philippschulte approved these changes

@anthony-gomez-fastly anthony-gomez-fastly anthony-gomez-fastly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcaril @anthony-gomez-fastly @philippschulte