Skip to content

[CDTOOL-1051] add get and list operations for ngwaf requests #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 11, 2025
Merged

[CDTOOL-1051] add get and list operations for ngwaf requests #688

merged 7 commits into from
Jun 11, 2025

Conversation

anthony-gomez-fastly
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly commented Jun 5, 2025 •
edited
Loading

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1051-ngwaf-requests branch from 6b58068 to 9ebf3f1 Compare June 5, 2025 15:38
@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1051-ngwaf-requests branch from 9ebf3f1 to e0b3eb5 Compare June 5, 2025 15:39
@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review June 5, 2025 15:39
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner June 5, 2025 15:39
anthony-gomez-fastly
anthony-gomez-fastly commented Jun 5, 2025
View reviewed changes
philippschulte
philippschulte previously requested changes Jun 10, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just minor comments updates necessary. Thanks

@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1051-ngwaf-requests branch from 644e31e to 7c7aa4d Compare June 10, 2025 15:00
philippschulte
philippschulte approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anthony-gomez-fastly anthony-gomez-fastly merged commit 8ac4087 into main Jun 11, 2025
7 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the CDTOOL-1051-ngwaf-requests branch June 11, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippschulte philippschulte philippschulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthony-gomez-fastly @philippschulte