Skip to content

[CDTOOL-1050] adds CRUD operations for the redactions portion of the ngwaf API #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 2, 2025
Merged

[CDTOOL-1050] adds CRUD operations for the redactions portion of the ngwaf API #685

merged 4 commits into from
Jun 2, 2025

Conversation

anthony-gomez-fastly
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner May 30, 2025 18:27
@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1050-ngwaf-redactions branch from f5235cb to bc20e78 Compare May 30, 2025 18:28
philippschulte
philippschulte previously requested changes May 31, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Please ask Kevin about regulating the possible field values and please update the test suite by creating a test workspace first.

philippschulte
philippschulte approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1050-ngwaf-redactions branch from 2362414 to 216dcdb Compare June 2, 2025 17:06
@anthony-gomez-fastly anthony-gomez-fastly merged commit 056d71c into main Jun 2, 2025
7 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the CDTOOL-1050-ngwaf-redactions branch June 2, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippschulte philippschulte philippschulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthony-gomez-fastly @philippschulte