Skip to content

[CDTOOL-1048] add support for the events portion of the ngwaf api #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 2, 2025
Merged

[CDTOOL-1048] add support for the events portion of the ngwaf api #684

merged 4 commits into from
Jun 2, 2025

Conversation

anthony-gomez-fastly
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly commented May 27, 2025 •
edited
Loading

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1048-ngwaf-events branch 2 times, most recently from 25d5c60 to 14cbf60 Compare May 30, 2025 18:47
@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review May 30, 2025 18:53
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner May 30, 2025 18:53
@kpfleming kpfleming changed the title [CD-TOOL-1048] add support for the events portion of the ngwaf api [CDTOOL-1048] add support for the events portion of the ngwaf api Jun 2, 2025
kpfleming
kpfleming approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes requested, but no need for a re-review.

@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1048-ngwaf-events branch from 14cbf60 to 8424f08 Compare June 2, 2025 16:37
anthony-gomez-fastly and others added 3 commits June 2, 2025 12:37
@anthony-gomez-fastly @kpfleming
Update fastly/ngwaf/v1/events/api_list.go
93f9e21 
Co-authored-by: Kevin P. Fleming <kpfleming@users.noreply.github.com>
@anthony-gomez-fastly
remove annotations
018af52
@anthony-gomez-fastly
fmt
e0450b0
@anthony-gomez-fastly anthony-gomez-fastly merged commit bdd2932 into main Jun 2, 2025
7 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the CDTOOL-1048-ngwaf-events branch June 2, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpfleming kpfleming kpfleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthony-gomez-fastly @kpfleming