Skip to content

ci(pr_test): make changelog check only run for non bot users #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 4, 2025
Merged

ci(pr_test): make changelog check only run for non bot users #628

merged 4 commits into from
Mar 4, 2025

Conversation

anthony-gomez-fastly
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@anthony-gomez-fastly anthony-gomez-fastly added the Skip-Changelog Do not check for changelog diff label Mar 3, 2025
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner March 3, 2025 16:07
@kpfleming
Copy link
Contributor

I suspect we'll also have to move dependabot-changelog-update back to its own workflow, otherwise when the commit occurs this workflow will be blocked (to avoid a potential circular loop).

@kpfleming kpfleming requested review from kpfleming and removed request for philippschulte March 3, 2025 16:24
@anthony-gomez-fastly anthony-gomez-fastly force-pushed the selectively-run-changelog-checks branch from 1983366 to e727c8e Compare March 3, 2025 17:55
kpfleming
kpfleming previously approved these changes Mar 3, 2025
View reviewed changes
@anthony-gomez-fastly @kpfleming
Update .github/workflows/pr_test.yml
c9d7fb4 
Co-authored-by: Kevin P. Fleming <kpfleming@users.noreply.github.com>
@kpfleming kpfleming merged commit 1b951ef into main Mar 4, 2025
7 checks passed
@kpfleming kpfleming deleted the selectively-run-changelog-checks branch March 4, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpfleming kpfleming kpfleming approved these changes

Assignees
No one assigned
Labels
Skip-Changelog Do not check for changelog diff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthony-gomez-fastly @kpfleming