Skip to content

build(go.mod): upgrade go to 1.23.6 from 1.22.0 #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 26, 2025
Merged

build(go.mod): upgrade go to 1.23.6 from 1.22.0 #624

merged 3 commits into from
Feb 26, 2025

Conversation

anthony-gomez-fastly
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly commented Feb 26, 2025 •
edited
Loading

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Are there any considerations that need to be addressed for release?

I don't think we need to tell people we are upgrading to 1.23.6, but happy to open it up to discussions

Various dependabot upgrades require 1.23 (618 and 610)

philippschulte
philippschulte previously requested changes Feb 26, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please share which dependency of go-fastly requires an upgrade from 1.22 to 1.23.

@philippschulte
Copy link
Member

Sorry, I didn't notice that is is just a draft!

@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review February 26, 2025 19:00
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner February 26, 2025 19:00
philippschulte
philippschulte previously approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just some nit picks. Can you please share in the description what dependency requires us to bump Go to 1.23?

philippschulte
philippschulte approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anthony-gomez-fastly anthony-gomez-fastly merged commit 41b8793 into main Feb 26, 2025
7 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the upgrade-go-to-1.23.6 branch February 26, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippschulte philippschulte philippschulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthony-gomez-fastly @philippschulte