Fix compute ACL lookup call for status 204 #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippschulte
commented
Feb 6, 2025
kpfleming
previously approved these changes
Feb 6, 2025
SahibYar
reviewed
Feb 6, 2025
kpfleming
reviewed
Feb 10, 2025
…leaks (fastly#592) Co-authored-by: Sahib Yar <s.yar@centroidsol.com>
aa51300 to
b364f6c
Compare
| @@ -33,6 +34,10 @@ func Lookup(c *fastly.Client, i *LookupInput) (*ComputeACLEntry, error) { | |||
| } | |||
| defer resp.Body.Close() | |||
|
|
|||
| if resp.StatusCode != http.StatusOK { | |||
There was a problem hiding this comment.
In the case that no matching IP was found, the API will return a 204 No Content. This is not an error condition, rather a lack of results.
Instead of returning an error here, consider alternatives to allow the caller to distinguish between an error (e.g. network timeout) and this case. One idea is to return (nil, nil).
philippschulte
added a commit
that referenced
this pull request
Feb 12, 2025
This reverts commit 29832ac.
philippschulte
added a commit
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #594.
All Submissions:
Changes to Core Features: