Skip to content

Followup fixes for Pushpin integration #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 19, 2025
Merged

Followup fixes for Pushpin integration #1520

merged 5 commits into from
Aug 19, 2025

Conversation

harmony7
Copy link
Member

@harmony7 harmony7 commented Aug 19, 2025 •
edited
Loading

This PR is a followup to #1509 that includes the following fixes:

  • Fix to Pushpin context that inadvertently left out the path to the routes file and the cleanup function when building the context
  • Adds an output message indicating when "Experimental Pushpin mode" is enable
  • Makes Pushpin-related logs slightly less noisy

@harmony7 harmony7 requested a review from a team as a code owner August 19, 2025 11:06
anthony-gomez-fastly
anthony-gomez-fastly approved these changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, any test changes needed?

@harmony7
Copy link
Member Author

thanks.

kpfleming
kpfleming requested changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes, mostly just using the functions from the text package for consistency.

@harmony7
Copy link
Member Author

I've applied changes from review

For reference, here's what the output looks like now:

Without verbose:
image

With verbose:
image

@harmony7 harmony7 requested a review from kpfleming August 19, 2025 15:27
@kpfleming
Copy link
Contributor

That looks great!

@kpfleming kpfleming enabled auto-merge (squash) August 19, 2025 16:25
@kpfleming kpfleming merged commit 65a47a5 into main Aug 19, 2025
29 of 40 checks passed
@kpfleming kpfleming deleted the kats/fanout-fixes branch August 19, 2025 16:34
@BrewTestBot BrewTestBot mentioned this pull request Aug 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpfleming kpfleming kpfleming approved these changes

@anthony-gomez-fastly anthony-gomez-fastly anthony-gomez-fastly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harmony7 @kpfleming @anthony-gomez-fastly