Skip to content

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Aug 15, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • What is the user impact of this change?

There is no impact to the user. The changes as described in this PR are internal only. No package paths have changed, nor have any package names changed, nor have any CLI commands/subcommands changed. The only change has been to the go-fastly calls to match the latest go-fastly interface.

Are there any considerations that need to be addressed for release?

I have an internal conversation going to ascertain if this PR should be doing more (e.g. renaming command from domains-v1 to domain-management, as well as renaming the package path from domainv1 to domainmanagement). But even if we do want to go ahead with those changes we'll likely want to do that in a follow-up PR.

@Integralist Integralist requested a review from a team as a code owner August 15, 2025 12:09
@Integralist Integralist requested a review from rcaril August 15, 2025 12:09
Copy link
Contributor

@rcaril rcaril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Further validated locally.

@Integralist
Copy link
Collaborator Author

Thanks @rcaril am I ok to merge this or would you and your team prefer to handle merging?

@rcaril
Copy link
Contributor

rcaril commented Aug 15, 2025

Thanks @rcaril am I ok to merge this or would you and your team prefer to handle merging?

I spoke to the team, it looks we prefer to merge on our side. I'll go ahead and do that.

@rcaril rcaril merged commit a089761 into main Aug 15, 2025
12 checks passed
@rcaril rcaril deleted the integralist/domainmanagment branch August 15, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants