Skip to content

Conversation

kpfleming
Copy link
Contributor

The token should not be displayed except when the user specifically requests it; instead of displaying it automatically, tell the user which command they can run to display it if they need to.

New output:

kpfleming@kpfleming:~/src/fastly/cli$ ./fastly --profile testing sso
IMPORTANT: We're going to authenticate the 'testing' profile and make it the default. We need to open your browser to authenticate you.

Do you want to continue? [y/N]: y

INFO: Starting a local server to handle the authentication flow.

We're opening the following URL in your default web browser so you may authenticate with Fastly:
	https://accounts.fastly.com/realms/fastly/protocol/openid-connect/auth?REDACTED

SUCCESS: Session token has been stored, use 'fastly profile token testing' to display it.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • What is the user impact of this change?

Are there any considerations that need to be addressed for release?

The token should not be displayed except when the user specifically
requests it; instead of displaying it automatically, tell the user
which command they can run to display it if they need to.
@kpfleming kpfleming requested a review from kailan June 10, 2025 10:52
@kpfleming kpfleming requested a review from a team as a code owner June 10, 2025 10:52
@kpfleming kpfleming requested a review from philippschulte June 10, 2025 10:52
Copy link
Member

@kailan kailan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thank you

Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kpfleming kpfleming merged commit 9e43afc into fastly:main Jun 10, 2025
12 of 15 checks passed
@kpfleming kpfleming deleted the cdtool-1085 branch June 10, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants