Skip to content

Conversation

anthony-gomez-fastly
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

@kpfleming
Copy link
Contributor

kpfleming commented May 8, 2025

Just to note, the backend test changes in this PR are not needed for the upgrade to go-fastly itself; they are needed because the CLI commands can output the JSON from the API unmodified, and that JSON now includes the "PreferIPv6" property. Making the CLI tolerant of those sorts of changes would be a very large project.

Any PR whose CI jobs ran after yesterday (or maybe Tuesday) would have had the same failures.

@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review May 9, 2025 15:47
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner May 9, 2025 15:47
@anthony-gomez-fastly anthony-gomez-fastly merged commit 44a36f8 into main May 9, 2025
12 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the upgrade-go-fastly branch May 9, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants