[deliver] Fix altool not logging errors #29545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
My bad. Didn't mean to just empty at you. Anyways a11 confirmed it fixed it on their end as well |
I second this. In my case the logs that now appear for me are not fixable in code and after I used this fork I fixed my issue in 2 minutes. |
getaaron
approved these changes
Apr 19, 2025
|
There are some cases where this will result in printing too many logs, but for now I want to get the upload errors unblocked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not run all the tests as the comment suggested. To be entirely honest, I'm not sure how. I have only done enough ruby to be dangerous but not enough familiarity to know how to run all the tools fastlane leverages. Anywho, other devs were prompting me that they were encountering this same issue so hopefully this PR resolves it. Besides, I suspect the GitHub pipeline will run any necessary tests. Without further ado:
Altool appears to have changed the format of their cli output. As a result the error regex is no longer matching. This PR simply removes that regex expression. I don't think we should be filtering out errors anyways and should instead log errors verbosely so that the developer can get as much information as possible to debug. This resolves this issue:
#29368
Note the error itself won't be resolved, but it will now properly log the errors so developers can resolve whatever is wrong on their end. In my case I needed to bump my minimum supported OS version and I needed to auth credentials.