Removes invalid template name parameter #29501
Conversation
|
This is an undocumented parameter, I think failure is due to Apple API failures, not this parameter specifically. |
|
This fix worked for me. |
|
Please merge this. |
|
Can someone please merge this? |
|
Please merge this. Thank you. |
Until this PR will be merged fastlane#29501
|
Are there any plans to merge this ? |
|
please merge, the error is breaking fastlane deployment. |
|
This is basically not working if you add entitlements to the provisioning profile creation during the fastlane sigh command. |
|
Any update on this being merged or the error being fixed ? |
|
Hi, any update on merging this fix? |
|
@heitor598 @redreceipt I'm running into this issue, are we happy to merge this change? |
|
This is issue makes iOS deployment capability nullified please merge this asap! @redreceipt |
| templateName: template_name | ||
| # Unsupported | ||
| # https://developer.apple.com/documentation/appstoreconnectapi/profilecreaterequest/data-data.dictionary/attributes-data.dictionary | ||
| # templateName: template_name |
There was a problem hiding this comment.
👋 Thanks a lot for this change!
I don't think we need this comment. The git history and this pr should be enough to understand why we deleted it.
We also should clean up the callers and Sigh options, for example:
Spaceship::ConnectAPI::Profile.create(..., template_name: Sigh.config[:template_name]) |
It seems we have a duplicated pr: #29591 |
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Closes #29498
Description
templateNameis no longer a valid parameterhttps://developer.apple.com/documentation/appstoreconnectapi/profilecreaterequest/data-data.dictionary/attributes-data.dictionary
Testing Steps