Add keychain_name param to setup_ci action #29482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit it was impossible to provide a `name` param to the `create_keychain` action which is called by the `setup_ci` action. This commit adds a `keychain_name` param to the `setup_ci` action which will be passed as `name` to the `create_keychain` action.
|
I've not checked off the This test also fail for me on the Please let me know if I can check it off if it succeeds on the CI. |
It seems like some more setup was needed for the tests to pass on the CI. By moving the test, the setup should already be done.
Yeah this happens to me as well if I don't have the visionOS SDK installed locally I think. But it passed on CI so I think it's ok 🙂 |
AliSoftware
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Before this change it was impossible to provide a
nameparam to thecreate_keychainaction which is called by thesetup_ciaction. This change adds akeychain_nameparam to thesetup_ciaction which will be passed asnameto thecreate_keychainaction.We use a self hosted MacOS GitHub Actions runner which can run multiple jobs in parallel. When the setup is started twice (or more) exactly at the same time, the creation of the keychain sometimes fails in one of the jobs with the following error:
This happens because of a timing issue where the first job creates the keychain before the second job is able to tell this happened and subsequently also tries to create the keychain.
To mitigate this issue, we would like to give each job its own keychain (which is actually preferred for other reason too). But currently the
setup_ciaction does not allow us to do this.Description
The
setup_ciaction has a newkeychain_nameparam which is used as thenameparam of thecreate_keychainaction.