Skip to content

moves note about being overwritten to top of README #27961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

justinvallely
Copy link
Contributor

@justinvallely justinvallely commented Nov 13, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Match generates and overwrites a README.md file in each repository in which it's deployed. We've often made the mistake of editing the README with our own information only to have it overwritten. Moving the note about the README being auto-generated to the top of the file will help the warning stand out to potential editors.

Description

This is a simple text change that doesn't affect the performance of any fastlane tools.

Testing Steps

Testing was done by viewing the changes in a GitHub markdown renderer:

Screenshot 2024-11-13 at 10 37 45 AM

@AliSoftware AliSoftware merged commit aa33711 into fastlane:master Mar 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants