Skip to content

Bump xcpretty to version 0.4.0 #26657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2024
Merged

Bump xcpretty to version 0.4.0 #26657

merged 1 commit into from
Nov 26, 2024

Conversation

revolter
Copy link
Collaborator

@revolter revolter commented Oct 22, 2024 •
edited
Loading

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Resolves #21192.

Arose from xcpretty/xcpretty#394.

Description

Testing Steps

@revolter revolter force-pushed the revolter/bump-xcpretty-0.4.0 branch from ed3890a to 133c17a Compare October 22, 2024 14:26
@revolter revolter force-pushed the revolter/bump-xcpretty-0.4.0 branch from 133c17a to 7f2656b Compare October 22, 2024 14:42
@revolter revolter requested a review from joshdholtz October 22, 2024 15:59
@revolter revolter mentioned this pull request Oct 22, 2024
Closed
4 tasks
@revolter revolter requested a review from lacostej November 8, 2024 20:36
taquitos
taquitos approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@taquitos taquitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@revolter
Copy link
Collaborator Author

Wow, right this minute I opened the Slack thread to check for updates, and at the same time I received the notification email 🤯

Thanks for the review ❤️

@revolter revolter merged commit f4bdf21 into master Nov 26, 2024
7 checks passed
@revolter revolter deleted the revolter/bump-xcpretty-0.4.0 branch November 26, 2024 17:53
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Merged
@jeffremer
Copy link

FWIW, it appears that xcpretty@0.4.0 has an issue where it causes UI tests bail immediately while running if there is test failure. This has the side effect of preventing us from gathering test results since the test suite doesn't finish running.

@revolter
Copy link
Collaborator Author

revolter commented Feb 1, 2025

@jeffremer, thanks for letting me know! 🙏🏻 Really sorry for introducing that crash. I created xcpretty/xcpretty#400 that hopefully fixes it, and if it does, I will follow through to get it into fastlane as well 🤞🏻

@thevenkat94
Copy link

FWIW, it appears that xcpretty@0.4.0 has an issue where it causes UI tests bail immediately while running if there is test failure. This has the side effect of preventing us from gathering test results since the test suite doesn't finish running.

So, what we have to do ..?

@revolter
Copy link
Collaborator Author

So, what we have to do ..?

I am working on getting the fix into a future fastlane update 🤞🏻

@revolter revolter mentioned this pull request Mar 26, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taquitos taquitos taquitos approved these changes

@joshdholtz joshdholtz Awaiting requested review from joshdholtz

@lacostej lacostej Awaiting requested review from lacostej

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability in Rouge 2.0.7
4 participants
@revolter @jeffremer @thevenkat94 @taquitos