-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[spaceship] New AppleID Auth with SRP #26415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3425a74
to
2136791
Compare
thank you so much . problem fixed ! work fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏 thank you for your hard work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi there, thanks a lot for the fix. Just wanted to know that if setting the env |
Hey @Martin-Gonzalez90 can you brief where exactly this ENV needs to be set? i am also facing the same issue although appstore connect pwd is correct, its not connecting and account got locked and now Access is Forbidden |
I did set it, and it didn't work but functioned without it, so try running without it first. Add a .env file to your Fastlane folder if you think you need it. |
I updated fastlane to latest version and set the env but still failed, but then suddenly started to work, so I don't know if this is a real fix or if the service was recovered. |
Hello and thanks for hard work . i try your way and 503 error fixed . but i have new problem a , i got AppleID Session , but i see after some hours session will not work and i must get new session for this appleid ! whats the problem ? i mean every 4-5 hours session not work and i must get new session ! |
Hello @davidmdt21 , I have read the latest Fastlane auth code and attempted to implement this auth using Golang Language. Currently, It's not working. Request the Api https://idmsa.apple.com/appleauth/auth/signin/complete?isRememberMeEnabled=false, it still returns an error: |
I just had this problem, until I added all the code that needed to be filled with zeros. |
Just want to note: we use an Apple App Store API key instead of a Apple ID. After updating to this version (
Downgrading to |
Other than updating the fastlane version what are the next steps for making this work? Would be helpful to get some documentation update maybe please since for some of us may be hard to understand what we need exactly to do to make this work again. |
After I run unset FASTLANE_PASSWORD
unset FASTLANE_APP_SPECIFIC_PASSWORD
unset FASTLANE_SESSION
unset FASTLANE_USE_LEGACY_PRE_SIRP_AUTH spaceauth started to work |
Hey, thanks for the response ... for me I keep getting the same error and I don't know what to do anymore ... I've included in my Gemfile this 2 and installed them:
I really don't know what I have to do, or what to set so the authentication works ... do you changed something else or? |
Nope, I'm using directly fastlane v2.225.0 |
Could you tell me where zero-padding needs to be added? My current code has different responses when testing different accounts. Some can directly reach the two-factor authentication stage, while others consistently return a 401 response. |
Motivation and Context
Fixes #26368
Apple has released a new version of their Apple ID auth that uses SIRP (well, their version at least). Apple ID auth is broken so need to fix.
Description
Soooooo much of this work was done by @snatchev over a year ago when he discovered this optional new auth system. We have forked his fork of
sirp
and have it over at https://github.com/fastlane/fastlane-sirp. This is released under a new RubyGem calledfastlane-sirp
. Its not an exact implementation of SRP but its Apple's version 🤷♂️New
FASTLANE_USE_LEGACY_PRE_SIRP_AUTH
envThe
FASTLANE_USE_LEGACY_PRE_SIRP_AUTH
can be set to use the previous Apple ID auth logic (if it ever works again). I didn't feel comfortable deleting the path so put it behind this flag.Testing Steps
Update
Gemfile
and runbundle install
,bundle update fastlane
, orbundle update