Skip to content

Make test pass standalone #22268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 3, 2024
Merged

Make test pass standalone #22268

merged 10 commits into from
Oct 3, 2024

Conversation

lacostej
Copy link
Collaborator

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Some people's tests fail on their dev env.

Description

Testing Steps

taquitos
taquitos approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@taquitos taquitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
:shipit:

@lacostej lacostej force-pushed the fix/standalone_tests_1 branch from e1b10c6 to 187684d Compare September 30, 2024 19:45
@lacostej
Copy link
Collaborator Author

lacostej commented Oct 1, 2024

Not really sure why this error comes now

/Applications/Xcode-15.2.0.app/Contents/Developer/usr/bin/xcodebuild -resolvePackageDependencies -workspace gym/spec/fixtures/projects/projectBasedOnInheritance/ExampleWithInheritedXcconfig.xcworkspace -scheme "Target B" build
Command line invocation:
    /Applications/Xcode-15.2.0.app/Contents/Developer/usr/bin/xcodebuild -resolvePackageDependencies -workspace gym/spec/fixtures/projects/projectBasedOnInheritance/ExampleWithInheritedXcconfig.xcworkspace -scheme "Target A" build

User defaults from command line:
    IDEPackageSupportUseBuiltinSCM = YES

2024-10-01 07:40:36.033 xcodebuild[56563:52022096] Writing error result bundle to /var/folders/3n/52m9bkhs7fl5mzc46rvdk2dh0000gp/T/ResultBundle_2024-01-10_07-40-0036.xcresult
xcodebuild: error: Scheme Target A is not currently configured for the build action.

@lacostej
Copy link
Collaborator Author

lacostej commented Oct 1, 2024

So I've finally got this to pass but unsure why those changes are needed as I am no xcode project setup expert. It would be great if someone with more knowledge there could have a look at it.

The test that was failing and required the xcode project changes was introduced in 338f0a8 and wasn't building in that revision when ran standalone:

image

@lacostej lacostej mentioned this pull request Oct 1, 2024
Open
taquitos
taquitos reviewed Oct 2, 2024
View reviewed changes
taquitos
taquitos reviewed Oct 2, 2024
View reviewed changes
spaceship/spec/portal/provisioning_profile_template_spec.rb
@@ -1,4 +1,5 @@
describe Spaceship::Portal::ProvisioningProfileTemplate do
before { Spaceship.login }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, this is unexpected, but I trust you 😅

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

taquitos
taquitos reviewed Oct 2, 2024
View reviewed changes
deliver/spec/sync_screenshots_spec.rb
@@ -1,10 +1,8 @@
require 'deliver/sync_screenshots'
require 'fakefs/spec_helpers'
require_relative 'deliver_constants'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

taquitos
taquitos approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@taquitos taquitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great investigative work here. 🚀 it

@lacostej lacostej merged commit 91fbc4d into fastlane:master Oct 3, 2024
3 checks passed
@lacostej lacostej deleted the fix/standalone_tests_1 branch October 3, 2024 17:08
@github-actions github-actions bot mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taquitos taquitos taquitos approved these changes

Assignees
No one assigned
Labels
tool: deliver tool: gym tool: spaceship topic: swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lacostej @taquitos