[core] fix duplicate builds being matched in BuildWatcher #22256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@joshdholtz OMG thank you! I drove myself nuts on #22255 with fixing the tests and woke up wondering about just fixing the dupe condition and being done with it. 😆 |
Ha! I was also thinking of the most correct way to do it but I realized it was too late and I was too old to try to change that much code 🫠 It probably does need to be fixed properly at some point but 🤷♂️ Thanks for all your effort though! ❤️ |
LazyAfternoons
added a commit
to pagopa/io-app
that referenced
this pull request
Oct 4, 2024
## Short description This PR updates `fastlane` version to `2.223.1` which fixes an error with [duplicate builds](fastlane/fastlane#22256) being matched in BuildWatcher. ## List of changes proposed in this pull request - Update `Gemfile` and `Gemfile.lock` with the new fastlane version. ## How to test We can test this by running a new beta. If it doesn't work, we can revert it straight away.
LazyAfternoons
added a commit
to pagopa/io-app
that referenced
this pull request
Oct 8, 2024
## Short description This PR updates `fastlane` version to `2.223.1` which fixes an error with [duplicate builds](fastlane/fastlane#22256) being matched in BuildWatcher. ## List of changes proposed in this pull request - Update `Gemfile` and `Gemfile.lock` with the new fastlane version. ## How to test We can test this by running a new beta. If it doesn't work, we can revert it straight away.
rasberik
pushed a commit
to rasberik/fastlane
that referenced
this pull request
Oct 11, 2024
…2256) * [core] fix duplicate builds being matched in BuildWatcher * Fix lint and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #22248
Description
X.Y.0andX.Yℹ️ There is probably a more efficient solution but this one is has least logic change so most shippable ATM 😊 We can improve more later 🤷♂️
Testing Steps
Update
Gemfileand runbundle install,bundle update fastlane, orbundle update