Skip to content

Conversation

nicgodoy
Copy link
Contributor

@nicgodoy nicgodoy commented Apr 5, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Resolves #21944

Description

Added missing require 'ostruct' on erb_template_helper.rb to solve error:

/usr/local/lib/ruby/gems/2.7.0/gems/fastlane-2.220.0/fastlane/lib/fastlane/erb_template_helper.rb:20:in module:Fastlane': uninitialized constant Fastlane::OpenStruct (NameError)

Testing Steps

@brianhsux
Copy link

when will this issue be solved?

retyui added a commit to teradeiriz/therapydiaries-builds that referenced this pull request Jun 18, 2024
retyui added a commit to teradeiriz/therapydiaries-builds that referenced this pull request Jun 18, 2024
@gutenye
Copy link

gutenye commented Jul 2, 2024

Need this one, any updates on merging?

retyui added a commit to teradeiriz/therapydiaries-builds that referenced this pull request Jul 28, 2024
retyui added a commit to teradeiriz/therapydiaries-builds that referenced this pull request Jul 28, 2024
@username0x0a
Copy link

How's this not resolved yet after half a year? 🤔

@username0x0a
Copy link

@joshdholtz @revolter @giginet pls guys.

@revolter revolter changed the title Fix Update erb_template_helper.rb with require 'ostruct' to solve uninitialized constant Fastlane::OpenStruct (NameError) Add missing require 'ostruct' in erb_template_helper.rb to solve uninitialized constant Fastlane::OpenStruct (NameError) Oct 3, 2024
Copy link
Collaborator

@revolter revolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we're already requiring this in another file:

so I wouldn't expect this to break anything (since I didn't actually test this)

@revolter
Copy link
Collaborator

revolter commented Oct 3, 2024

I don't think that the failed test is caused by this PR's change, especially since CircleCI flagged it as flaky:

image

so I'll go ahead and merge it.

@revolter revolter merged commit 9570878 into fastlane:master Oct 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] uninitialized constant Fastlane::OpenStruct (NameError) with release 2.220.0
7 participants