Skip to content

[fastlane] added rubocop rule for no is_string in fastlane folder and actions #19069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2021
Merged

[fastlane] added rubocop rule for no is_string in fastlane folder and actions #19069

merged 1 commit into from
Jul 9, 2021

Conversation

joshdholtz
Copy link
Member

Motivation and Context

Finalizing all the great work that @crazymanish did!

Description

  • Fixed on action that still had is_string
  • Added rubocop IsString rule to fastlane directory
  • Fixed some test actions that had is_string

@google-cla google-cla bot added the cla: yes label Jul 9, 2021
@joshdholtz joshdholtz requested a review from crazymanish July 9, 2021 14:21
crazymanish
crazymanish approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@crazymanish crazymanish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely ☺️💯🚀

@joshdholtz joshdholtz merged commit c0b94f1 into master Jul 9, 2021
@joshdholtz joshdholtz deleted the joshdholtz-add-fastlane-actions-to-no-is_string-rubo branch July 9, 2021 15:33
@fastlane-bot
Copy link

Hey @joshdholtz 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@joshdholtz joshdholtz mentioned this pull request Jul 22, 2021
Merged
fastlane-bot
fastlane-bot reviewed Jul 22, 2021
View reviewed changes
Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.188.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fastlane-bot fastlane-bot fastlane-bot left review comments

@crazymanish crazymanish crazymanish approved these changes

Assignees
No one assigned
Labels
cla: yes status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshdholtz @fastlane-bot @crazymanish