Skip to content

[fastlane][plugins] Updated the ruby version in plugins' template #19046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2021
Merged

[fastlane][plugins] Updated the ruby version in plugins' template #19046

merged 1 commit into from
Jul 8, 2021

Conversation

crazymanish
Copy link
Member

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

  • Recently, after ruby3.0 support, Fastlane already dropped the Ruby2.4 support

Description

  • In this PR, Updated the ruby version in the plugins' template files for CircleCI and GitHub both

Testing Steps

@google-cla google-cla bot added the cla: yes label Jul 3, 2021
ainame
ainame approved these changes Jul 4, 2021
View reviewed changes
Copy link
Contributor

@ainame ainame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 👌

joshdholtz
joshdholtz approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@joshdholtz joshdholtz merged commit 4211702 into master Jul 8, 2021
@joshdholtz joshdholtz deleted the crazymanish-plugin-template-ruby-version branch July 8, 2021 20:15
@fastlane-bot
Copy link

Hey @crazymanish 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@joshdholtz joshdholtz mentioned this pull request Jul 22, 2021
Merged
fastlane-bot
fastlane-bot reviewed Jul 22, 2021
View reviewed changes
Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.188.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fastlane-bot fastlane-bot fastlane-bot left review comments

@joshdholtz joshdholtz joshdholtz approved these changes

@ainame ainame ainame approved these changes

Assignees
No one assigned
Labels
cla: yes status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crazymanish @fastlane-bot @joshdholtz @ainame