Skip to content

Conversation

crazymanish
Copy link
Member

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

  • is_string is slowly being replaced by type to make the docs clearer, options safer, and Swift generation more correct.
  • This PR does this for only appledoc action.

Description

  • Remove is_string: false/true from options

Testing Steps

  • No functionality changed, all existing unit tests should pass.

@google-cla google-cla bot added the cla: yes label Jul 2, 2021
@@ -125,63 +125,63 @@ def self.details
def self.available_options
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the last action for is_string migration! 🎉

Copy link
Contributor

@ainame ainame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! I happened to find a minor issue with the migration but overall looks great🙂

@crazymanish crazymanish requested a review from ainame July 4, 2021 15:31
Copy link
Contributor

@ainame ainame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ainame ainame requested a review from joshdholtz July 4, 2021 15:52
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥

@joshdholtz joshdholtz force-pushed the crazymanish-appledoc-clean-up branch from 22d4b75 to 778b5da Compare July 7, 2021 21:58
@joshdholtz joshdholtz merged commit 2a5ab70 into master Jul 8, 2021
@joshdholtz joshdholtz deleted the crazymanish-appledoc-clean-up branch July 8, 2021 14:16
@fastlane-bot
Copy link

Hey @crazymanish 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.188.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants