[scan] fix crash on TestResultParser when disable_xcpretty=true #17623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Fixes #16480
Description
test_results
used to early return whendisable_xcpretty
is true, but that would lead into a crash insidehandle_test_results
(the only method that callstest_results
) because it doesn't check for nil. I'm changing the early return to be inhandle_test_results
instead so the whole thing is skipped.Testing Steps
I believe any combination of
disable_xcpretty: true
withoutfail_build: false
would lead into the crash before this fix. I used to havefail_build: true
so I had never detected it myself.