Skip to content

[supply] skip sending user fraction if it's 1.0 when promoting track #17617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2020
Merged

[supply] skip sending user fraction if it's 1.0 when promoting track #17617

merged 2 commits into from
Nov 18, 2020

Conversation

rogerluan
Copy link
Member

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Resolves #17605

Description

Looks like after this PR #15668, we missed 1 instance where the rollout had to be checked. This PR adds the check for the last occurrence of rollout (to see if it's 1.0 and, if so, skip setting it).

Testing Steps

To test this branch, modify your Gemfile as:

gem "fastlane", :git => "https://github.com/fastlane/fastlane.git", :branch => "rogerluan-supply-skip-user-fraction-if-one"

@rogerluan rogerluan added the tool: supply upload_to_playstore label Nov 15, 2020
@google-cla google-cla bot added the cla: yes label Nov 15, 2020
@rogerluan rogerluan mentioned this pull request Nov 15, 2020
Closed
4 tasks
@joshdholtz joshdholtz force-pushed the rogerluan-supply-skip-user-fraction-if-one branch from 9e6cea7 to 01abcd7 Compare November 18, 2020 18:12
@google-cla
Copy link

google-cla bot commented Nov 18, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Nov 18, 2020
@joshdholtz
Copy link
Member

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 18, 2020
joshdholtz
joshdholtz approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Thanks for making this fix! ❤️

@joshdholtz joshdholtz merged commit e858fd3 into master Nov 18, 2020
@joshdholtz joshdholtz deleted the rogerluan-supply-skip-user-fraction-if-one branch November 18, 2020 19:17
@fastlane-bot
Copy link

Hey @rogerluan 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@joshdholtz joshdholtz mentioned this pull request Nov 19, 2020
Merged
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.168.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees
No one assigned
Labels
cla: yes status: released tool: supply upload_to_playstore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Supply] Google Api Error: badRequest: User fraction must be lower than one
3 participants
@rogerluan @joshdholtz @fastlane-bot