Skip to content

[fastlane] also support NO_COLOR for disabling colors #17611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 18, 2020
Merged

[fastlane] also support NO_COLOR for disabling colors #17611

merged 4 commits into from
Nov 18, 2020

Conversation

Cyberbeni
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

#17402

Description

Testing Steps

bundle exec fastlane env
NO_COLOR=1 bundle exec fastlane env

@google-cla google-cla bot added the cla: yes label Nov 14, 2020
@Cyberbeni
Copy link
Contributor Author

According to https://no-color.org/ the value is irrelevant, so NO_COLOR=0 should also disable color.

rogerluan
rogerluan approved these changes Nov 15, 2020
View reviewed changes
Copy link
Member

@rogerluan rogerluan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks for your contribution, and for taking care of this user's request! 🙌

@google-cla
Copy link

google-cla bot commented Nov 18, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Nov 18, 2020
@joshdholtz
Copy link
Member

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 18, 2020
joshdholtz
joshdholtz approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I added tests for this and also added doc updates - fastlane/docs#1007

Thanks for the contribution ❤️

@joshdholtz joshdholtz mentioned this pull request Nov 18, 2020
Merged
@joshdholtz joshdholtz changed the title Also support NO_COLOR for disabling colors [fastlane] also support NO_COLOR for disabling colors Nov 18, 2020
@joshdholtz joshdholtz merged commit cc08c69 into fastlane:master Nov 18, 2020
@joshdholtz joshdholtz mentioned this pull request Nov 19, 2020
Merged
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.168.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshdholtz joshdholtz joshdholtz approved these changes

@rogerluan rogerluan rogerluan approved these changes

Assignees
No one assigned
Labels
cla: yes status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cyberbeni @joshdholtz @fastlane-bot @rogerluan