Skip to content

[action] add support for arrays in in slather action for binary_basename and FL_SLATHER_BINARY_BASENAME environment variable #17606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2020
Merged

[action] add support for arrays in in slather action for binary_basename and FL_SLATHER_BINARY_BASENAME environment variable #17606

merged 2 commits into from
Nov 18, 2020

Conversation

jgongo
Copy link
Contributor

@jgongo jgongo commented Nov 13, 2020 •
edited by rogerluan
Loading

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

This PR resolves #17526

Description

I have specified the binary_basename parameter to be of type Array

I have added unit tests to test the binary_basename parameter both when used in the Fastfile and with the FL_SLATHER_BINARY_BASENAME environment variable.

Testing Steps

@google-cla google-cla bot added the cla: yes label Nov 13, 2020
@jgongo jgongo mentioned this pull request Nov 13, 2020
Closed
4 tasks
rogerluan
rogerluan reviewed Nov 15, 2020
View reviewed changes
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see you opening your first PR here @jgongo ❤️

Great job adding tests to cover all cases.

At first I thought that the changes to the parameter type would impact Ruby, but then you clearly proved that wrong via unit tests 🎉 Then I thought it'd certainly affect fastlane's Swift integration. In fact, I believe it does, however, since its default_value is false, slather in Swift is detected as a Bool 😬 so this is already broken in master - probably went unnoticed until now because there're no users using Slather in Fastlane.swift 😅

I'm fine to leave this as is, as I don't see an easy/quick workaround for that problem, but maybe @joshdholtz might have something in mind 😝

joshdholtz
joshdholtz approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Thanks so much for updating the tests ❤️ Really appreciate the contribution!

@joshdholtz joshdholtz changed the title Add support for arrays in FL_SLATHER_BINARY_BASENAME environment variable [action] add support for arrays in FL_SLATHER_BINARY_BASENAME environment variable Nov 18, 2020
@joshdholtz joshdholtz changed the title [action] add support for arrays in FL_SLATHER_BINARY_BASENAME environment variable [action] add support for arrays in in slather action for binary_basename and FL_SLATHER_BINARY_BASENAME environment variable Nov 18, 2020
@joshdholtz joshdholtz merged commit 5f9fef7 into fastlane:master Nov 18, 2020
@joshdholtz joshdholtz mentioned this pull request Nov 19, 2020
Merged
@jgongo jgongo deleted the 17526-FL_SLATHER_BINARY_BASENAME_arrays branch November 19, 2020 12:12
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.168.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rogerluan rogerluan rogerluan left review comments

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees
No one assigned
Labels
cla: yes status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of FL_SLATHER_BINARY_BASENAME in Slather action fails with arrays
4 participants
@jgongo @fastlane-bot @joshdholtz @rogerluan