Skip to content

[match] Support mac_installer_distribution certificate type #17561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

PaulTaykalo
Copy link
Contributor

@PaulTaykalo PaulTaykalo commented Nov 5, 2020

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Currently match doesn't allow to import mac_installer_distribution
This PR allows importing this type of certificate

Description

Let's say we want to have Mac Installer Distribution Certificate Type for MacOS.
From the documentation, we could see, that in order to perform this, we need to have match cal that will look like this

match(
	keychain_name: ENV['KEYCHAIN_NAME'], 
	keychain_password: keychain_password,
	additional_cert_types: ['mac_installer_distribution'], 
	readonly: true,
	generate_apple_certs: false,
	type: 'appstore',
	git_url: "https://rep.ur",
	git_branch: 'branch',
	app_identifier: ["identifier1", "identifier2"]
)

The issue is that there's no way to import mac_installer_distribution cert type, since it is not supported by match import

bundle exec fastlane match import \
  --platform 'macos' \
  --type "mac_installer_distribution" \
  --team_id 'XXXX' \
  --team_name 'My Team' \
  --app_identifier 'My app id \
  --git_branch 'branch' \
  --verbose

image

Testing Steps

  • Create a Mac AppStore Installer Distribution Certificate
  • Prepare .cer and .p12 files
  • Import profile using the command above
  • try to run match with mac_installer_distribution type certificate
  • Certificate should be successfully imported to the specified keychain

@google-cla google-cla bot added the cla: yes label Nov 5, 2020
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, good catch! Can't believe I missed this 🤦‍♂️ Really appreciate the contribution ❤️

@joshdholtz joshdholtz merged commit 0eae34b into fastlane:master Nov 18, 2020
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.168.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants