Skip to content

[spaceship] add client optional parameter in model helpers #17475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 19, 2020
Merged

[spaceship] add client optional parameter in model helpers #17475

merged 17 commits into from
Nov 19, 2020

Conversation

bolom
Copy link
Contributor

@bolom bolom commented Oct 20, 2020

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

#13962
allow to pass client parameter

@google-cla
Copy link

google-cla bot commented Oct 20, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 20, 2020
joshdholtz
joshdholtz requested changes Oct 23, 2020
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small things!

@google-cla
Copy link

google-cla bot commented Oct 23, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@joshdholtz
Copy link
Member

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 26, 2020
@joshdholtz
Copy link
Member

@googlebot I consent.

@joshdholtz joshdholtz changed the title add client optional parameter in helpers #1 [spaceship] add client optional parameter in model helpers Nov 18, 2020
joshdholtz
joshdholtz requested changes Nov 18, 2020
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found 3 spots that were missing client other than that I think we are good here!

@joshdholtz joshdholtz mentioned this pull request Nov 18, 2020
Closed
4 tasks
joshdholtz
joshdholtz approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 🔥 I reviewed it two more times tonight and found two more small fixes! But I think we should be good now 😊

@joshdholtz joshdholtz merged commit 2bdb19d into fastlane:master Nov 19, 2020
@joshdholtz joshdholtz mentioned this pull request Nov 19, 2020
Merged
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.168.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rogerluan rogerluan rogerluan left review comments

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees
No one assigned
Labels
cla: yes status: released tool: spaceship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bolom @joshdholtz @fastlane-bot @rogerluan @max-ott