Skip to content

[screengrab] Remove unused clean status bar options #15679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2019
Merged

[screengrab] Remove unused clean status bar options #15679

merged 1 commit into from
Nov 20, 2019

Conversation

rickclephas
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Forgot to remove some unused options in #15284.

@rickclephas rickclephas mentioned this pull request Nov 19, 2019
Closed
@janpio
Copy link
Member

janpio commented Nov 19, 2019

Didn't #15284 add these options?

@rickclephas
Copy link
Contributor Author

@janpio yeah it did but by mistake.
Those options were part of the first attempt to implement the clean status bar.
They were later moved to the screengrab-lib and aren't used (anymore).

janpio
janpio approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, so just leftover after refactoring/rework of PR and merged by accident.

@joshdholtz joshdholtz merged commit 777fe11 into fastlane:master Nov 20, 2019
@fastlane-bot
Copy link

Hey @rickclephas 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@joshdholtz joshdholtz mentioned this pull request Nov 22, 2019
Merged
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.137.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janpio janpio janpio approved these changes

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees
No one assigned
Labels
cla: yes status: released tool: screengrab
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rickclephas @janpio @fastlane-bot @joshdholtz @googlebot